[linux,dev-5.2,2/2] i2c: Aspeed: Add AST2600 compatible
diff mbox series

Message ID 1567629311-7553-2-git-send-email-eajames@linux.ibm.com
State New
Headers show
Series
  • [linux,dev-5.2,1/2] ARM: dts: Aspeed: Add I2C busses to AST2600 and Tacoma
Related show

Commit Message

Eddie James Sept. 4, 2019, 8:35 p.m. UTC
Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
 drivers/i2c/busses/i2c-aspeed.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Andrew Jeffery Sept. 5, 2019, 3:02 a.m. UTC | #1
On Thu, 5 Sep 2019, at 06:05, Eddie James wrote:
> Signed-off-by: Eddie James <eajames@linux.ibm.com>

Have you tested this on hardware? What was the outcome?

Andrew

> ---
>  drivers/i2c/busses/i2c-aspeed.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
> index 8931792..1943977 100644
> --- a/drivers/i2c/busses/i2c-aspeed.c
> +++ b/drivers/i2c/busses/i2c-aspeed.c
> @@ -1274,6 +1274,10 @@ static int aspeed_i2c_reset(struct aspeed_i2c_bus *bus)
>  		.compatible = "aspeed,ast2500-i2c-bus",
>  		.data = aspeed_i2c_25xx_get_clk_reg_val,
>  	},
> +	{
> +		.compatible = "aspeed,ast2600-i2c-bus",
> +		.data = aspeed_i2c_25xx_get_clk_reg_val,
> +	},
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, aspeed_i2c_bus_of_table);
> -- 
> 1.8.3.1
> 
>
Eddie James Sept. 5, 2019, 7:09 p.m. UTC | #2
On 9/4/19 10:02 PM, Andrew Jeffery wrote:
>
> On Thu, 5 Sep 2019, at 06:05, Eddie James wrote:
>> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> Have you tested this on hardware? What was the outcome?


Yes. The I2C devices I accessed through hwmon worked fine, including the 
PSU, tmp275, and ir35521. I didn't check every single device on every 
bus, but everything seemed to probe up fine.


Thanks,

Eddie


>
> Andrew
>
>> ---
>>   drivers/i2c/busses/i2c-aspeed.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
>> index 8931792..1943977 100644
>> --- a/drivers/i2c/busses/i2c-aspeed.c
>> +++ b/drivers/i2c/busses/i2c-aspeed.c
>> @@ -1274,6 +1274,10 @@ static int aspeed_i2c_reset(struct aspeed_i2c_bus *bus)
>>   		.compatible = "aspeed,ast2500-i2c-bus",
>>   		.data = aspeed_i2c_25xx_get_clk_reg_val,
>>   	},
>> +	{
>> +		.compatible = "aspeed,ast2600-i2c-bus",
>> +		.data = aspeed_i2c_25xx_get_clk_reg_val,
>> +	},
>>   	{ },
>>   };
>>   MODULE_DEVICE_TABLE(of, aspeed_i2c_bus_of_table);
>> -- 
>> 1.8.3.1
>>
>>
Joel Stanley Sept. 10, 2019, 5:44 p.m. UTC | #3
On Thu, 5 Sep 2019 at 19:10, Eddie James <eajames@linux.vnet.ibm.com> wrote:
>
>
> On 9/4/19 10:02 PM, Andrew Jeffery wrote:
> >
> > On Thu, 5 Sep 2019, at 06:05, Eddie James wrote:
> >> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> > Have you tested this on hardware? What was the outcome?

When probing I see these invalid resource warnings:

[    7.179489] aspeed-i2c-bus 1e78a080.i2c-bus: invalid resource
[    7.183615] aspeed-i2c-bus 1e78a080.i2c-bus: i2c bus 0 registered
(byte mode), irq 25

Can you please fix those?

Cheers,

Joel

Patch
diff mbox series

diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index 8931792..1943977 100644
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -1274,6 +1274,10 @@  static int aspeed_i2c_reset(struct aspeed_i2c_bus *bus)
 		.compatible = "aspeed,ast2500-i2c-bus",
 		.data = aspeed_i2c_25xx_get_clk_reg_val,
 	},
+	{
+		.compatible = "aspeed,ast2600-i2c-bus",
+		.data = aspeed_i2c_25xx_get_clk_reg_val,
+	},
 	{ },
 };
 MODULE_DEVICE_TABLE(of, aspeed_i2c_bus_of_table);