[SRU,D/E/Unstable,Pull] Enable Realtek Wireless Lan 8723DE
mbox series

Message ID 20190904180547.14809-1-kai.heng.feng@canonical.com
State New
Headers show
Series
  • [SRU,D/E/Unstable,Pull] Enable Realtek Wireless Lan 8723DE
Related show

Pull-request

https://git.launchpad.net/~kaihengfeng/linux lp1780590-unstable

Message

Kai-Heng Feng Sept. 4, 2019, 6:05 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1780590

[Impact]
There's no in-kernel support for Realtek 8723DE, so users need to use
out-of-tree DKMS which is not from Ubuntu archive. This has security
implication and should be avoided. Also this provides pretty bad user
experience.

[Fix]
Add support to Realtek 8723DE.
All commits are cherry-picked from Realtek maintained repo:
https://github.com/rtlwifi-linux/rtw88_8723de

[Test]
With the patch series applied, 8723DE can scan and connect to APs
succesfully. Also did some S3 smoke test, it continues to work.

[Regression Potential]
Low. The device in question was never supported, and if there's any
regression, we can count on Realtek Wireless team, thy are now pretty
responsive on upstream mailing list.

[Disco]
The following changes since commit 9155387474aad243521665dbb39cbb60fa2b2f28:

  KVM: PPC: Book3S: Add count cache flush parameters to kvmppc_get_cpu_char() (2019-09-03 23:06:56 -0400)

are available in the Git repository at:

  https://git.launchpad.net/~kaihengfeng/linux lp1780590-disco

for you to fetch changes up to f8ed6357e830b208af21dad780f34817c1d5ac69:

  UBUNTU: [Config] CONFIG_RTW88_8723DE=y (2019-09-04 15:56:47 +0800)

[Eoan]
The following changes since commit a0ba553e8433044b1351b3805f6f5af89712da39:

  UBUNTU: SAUCE: Input: elantech - enable middle button for one more ThinkPad (2019-08-30 11:54:30 -0500)

are available in the Git repository at:

  https://git.launchpad.net/~kaihengfeng/linux lp1780590-eoan

for you to fetch changes up to ba57d3bad694710d48b26e7cfc3d249f28fda2b5:

  UBUNTU: [Config] CONFIG_RTW88_8723DE=y (2019-09-04 15:54:15 +0800)

[Unstable]
The following changes since commit ff4e0cca519adb9b44d8fbaad998e159937a4b22:

  UBUNTU: Ubuntu-5.3.0-9.10 (2019-09-03 10:27:33 +0200)

are available in the Git repository at:

  https://git.launchpad.net/~kaihengfeng/linux lp1780590-unstable

for you to fetch changes up to c4eefc15ef3f978b69aacb8a348a06944e57971d:

  UBUNTU: [Config] CONFIG_RTW88_8723DE=y (2019-09-04 15:49:35 +0800)

Comments

Seth Forshee Sept. 11, 2019, 5:35 p.m. UTC | #1
On Thu, Sep 05, 2019 at 02:05:47AM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1780590
> 
> [Impact]
> There's no in-kernel support for Realtek 8723DE, so users need to use
> out-of-tree DKMS which is not from Ubuntu archive. This has security
> implication and should be avoided. Also this provides pretty bad user
> experience.
> 
> [Fix]
> Add support to Realtek 8723DE.
> All commits are cherry-picked from Realtek maintained repo:
> https://github.com/rtlwifi-linux/rtw88_8723de
> 
> [Test]
> With the patch series applied, 8723DE can scan and connect to APs
> succesfully. Also did some S3 smoke test, it continues to work.
> 
> [Regression Potential]
> Low. The device in question was never supported, and if there's any
> regression, we can count on Realtek Wireless team, thy are now pretty
> responsive on upstream mailing list.

I have not had a chance to review this yet, however I did want to ask --
has the driver been reviewed to ensure that it is suitable to be signed
by the build-time ephemaral module signing key? I.e. it does not expose
any interfaces to userspace which would compromise kernel lockdown?

Thanks,
Seth