Patchwork [2/8] configure: Make missing pkg-config an error rather than a warning

login
register
mail settings
Submitter Stefan Hajnoczi
Date Sept. 21, 2011, 10:26 a.m.
Message ID <1316600766-5541-3-git-send-email-stefanha@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/115764/
State New
Headers show

Comments

Stefan Hajnoczi - Sept. 21, 2011, 10:26 a.m.
From: Peter Maydell <peter.maydell@linaro.org>

If pkg-config doesn't exist then make configure fail immediately
with a useful error message. Now that glib is a required dependency,
proceeding despite the missing pkg-config will just cause us to
fail later with a misleading message about glib not being present.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 configure |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/configure b/configure
index 414317a..9ab3ab4 100755
--- a/configure
+++ b/configure
@@ -1340,8 +1340,8 @@  fi
 # pkg-config probe
 
 if ! has $pkg_config; then
-  echo warning: proceeding without "$pkg_config" >&2
-  pkg_config=/bin/false
+  echo "Error: pkg-config binary '$pkg_config' not found"
+  exit 1
 fi
 
 ##########################################