[02/22] xive: minor cleanup of the interface
diff mbox series

Message ID 20190903170413.4373-3-clg@kaod.org
State New
Headers show
Series
  • xive: new interfaces, fixes and cleanups in a new driver
Related show

Checks

Context Check Description
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco success Signed-off-by present
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master
snowpatch_ozlabs/apply_patch success Successfully applied on branch master (7b12d5489fcfd73ef7ec0cb27eff7f8a5f13b238)

Commit Message

Cédric Le Goater Sept. 3, 2019, 5:03 p.m. UTC
The XIVE driver exposes an API to the core OPAL layer and to other
OPAL drivers. This is a minor cleanup preparing ground for POWER10.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 include/interrupts.h | 1 -
 include/skiboot.h    | 1 -
 include/xive.h       | 5 ++---
 core/fast-reboot.c   | 2 +-
 hw/slw.c             | 1 +
 hw/xive.c            | 4 ++--
 6 files changed, 6 insertions(+), 8 deletions(-)

Patch
diff mbox series

diff --git a/include/interrupts.h b/include/interrupts.h
index d1ee5c4c112b..dfd48f2f2d59 100644
--- a/include/interrupts.h
+++ b/include/interrupts.h
@@ -184,7 +184,6 @@  extern uint32_t get_ics_phandle(void);
 struct cpu_thread;
 
 extern void reset_cpu_icp(void);
-extern void reset_cpu_xive(void);
 extern void icp_send_eoi(uint32_t interrupt);
 extern void icp_prep_for_pm(void);
 extern void icp_kick_cpu(struct cpu_thread *cpu);
diff --git a/include/skiboot.h b/include/skiboot.h
index 96d25b83dac3..4258955484ae 100644
--- a/include/skiboot.h
+++ b/include/skiboot.h
@@ -298,7 +298,6 @@  enum wakeup_engine_states {
 extern enum wakeup_engine_states wakeup_engine_state;
 extern bool has_deep_states;
 extern void nx_p9_rng_late_init(void);
-extern void xive_late_init(void);
 
 
 
diff --git a/include/xive.h b/include/xive.h
index d0c91069c83b..8414e63c918e 100644
--- a/include/xive.h
+++ b/include/xive.h
@@ -52,8 +52,7 @@  void xive_cpu_callin(struct cpu_thread *cpu);
  */
 void *xive_get_trigger_port(uint32_t girq);
 
-/* To be used by special EOI override in PSI */
-struct irq_source;
-void __xive_source_eoi(struct irq_source *is, uint32_t isn);
+extern void xive_cpu_reset(void);
+extern void xive_late_init(void);
 
 #endif /* __XIVE_H__ */
diff --git a/core/fast-reboot.c b/core/fast-reboot.c
index 9631eb96d072..9611652d8c96 100644
--- a/core/fast-reboot.c
+++ b/core/fast-reboot.c
@@ -324,7 +324,7 @@  void __noreturn fast_reboot_entry(void)
 	prlog(PR_DEBUG, "RESET: CPU 0x%04x reset in\n", this_cpu()->pir);
 
 	if (proc_gen == proc_gen_p9) {
-		reset_cpu_xive();
+		xive_cpu_reset();
 	} else if (proc_gen == proc_gen_p8) {
 		/* We reset our ICP first ! Otherwise we might get stray
 		 * interrupts when unsplitting
diff --git a/hw/slw.c b/hw/slw.c
index bb88f0f109cb..238e64c4616b 100644
--- a/hw/slw.c
+++ b/hw/slw.c
@@ -22,6 +22,7 @@ 
 #include <opal-api.h>
 #include <nvram.h>
 #include <sbe-p8.h>
+#include <xive.h>
 
 #include <p9_stop_api.H>
 #include <p8_pore_table_gen_api.H>
diff --git a/hw/xive.c b/hw/xive.c
index 7b034f9795a3..32799718dd54 100644
--- a/hw/xive.c
+++ b/hw/xive.c
@@ -2636,7 +2636,7 @@  static int64_t xive_source_set_xive(struct irq_source *is,
 	return __xive_set_irq_config(is, isn, server, prio, isn, true, true);
 }
 
-void __xive_source_eoi(struct irq_source *is, uint32_t isn)
+static void __xive_source_eoi(struct irq_source *is, uint32_t isn)
 {
 	struct xive_src *s = container_of(is, struct xive_src, is);
 	uint32_t idx = isn - s->esb_base;
@@ -4811,7 +4811,7 @@  static void xive_reset_mask_source_cb(struct irq_source *is,
 	}
 }
 
-void reset_cpu_xive(void)
+void xive_cpu_reset(void)
 {
 	struct cpu_thread *c = this_cpu();
 	struct xive_cpu_state *xs = c->xstate;