From patchwork Tue Sep 20 22:10:19 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/5] libsas: disable scanning lun > 0 on ata devices Date: Tue, 20 Sep 2011 12:10:19 -0000 From: Dan Williams X-Patchwork-Id: 115634 Message-Id: <20110920221008.1094.34064.stgit@localhost6.localdomain6> To: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org Cc: Luben Tuikov , jgarzik@pobox.com, JBottomley@parallels.com, Jack Wang , Xiangliang Yu , Mark Salyzyn , Darrick Wong Currently mvsas and pm8001 have custom ->slave_alloc implementations to achieve this. Uplevel it for all libsas drivers as isci encounters problems with atapi devices when scanning past lun0. Just do what Darrick suggested [1], and limit the scan for ata devices. [1] http://marc.info/?l=linux-scsi&m=116604101119861&w=2 Cc: Darrick Wong Cc: Xiangliang Yu Cc: Jack Wang Cc: Mark Salyzyn Cc: Luben Tuikov Signed-off-by: Dan Williams Signed-off-by: Dan Williams Acked-by: Jeff Garzik --- drivers/scsi/scsi_transport_sas.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c index c6fcf76..9d9330a 100644 --- a/drivers/scsi/scsi_transport_sas.c +++ b/drivers/scsi/scsi_transport_sas.c @@ -1545,8 +1545,14 @@ int sas_rphy_add(struct sas_rphy *rphy) if (identify->device_type == SAS_END_DEVICE && rphy->scsi_target_id != -1) { - scsi_scan_target(&rphy->dev, 0, - rphy->scsi_target_id, SCAN_WILD_CARD, 0); + int lun; + + if (identify->target_port_protocols & SAS_PROTOCOL_SSP) + lun = SCAN_WILD_CARD; + else + lun = 0; + + scsi_scan_target(&rphy->dev, 0, rphy->scsi_target_id, lun, 0); } return 0;