From patchwork Fri Aug 30 12:14:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Brauner X-Patchwork-Id: 1155909 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ubuntu.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46Kdhm1pdSz9sMr; Fri, 30 Aug 2019 22:15:04 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1i3fnu-0007fC-Ng; Fri, 30 Aug 2019 12:14:58 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1i3fns-0007ek-0b for kernel-team@lists.ubuntu.com; Fri, 30 Aug 2019 12:14:56 +0000 Received: from [213.220.153.21] (helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1i3fnf-0004AR-Bt; Fri, 30 Aug 2019 12:14:43 +0000 From: Christian Brauner To: kernel-team@lists.ubuntu.com, seth.forshee@canonical.com Subject: [PATCH][SRU][Disco] UBUNTU: SAUCE: shiftfs: mark slab objects SLAB_RECLAIM_ACCOUNT Date: Fri, 30 Aug 2019 14:14:31 +0200 Message-Id: <20190830121431.8498-1-christian.brauner@ubuntu.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stgraber@ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1842059 Shiftfs does not mark it's slab cache as reclaimable. While this is not a big deal it is not nice to the kernel in general. The shiftfs cache is not so important that it can't be reclaimed. Signed-off-by: Christian Brauner Acked-by: Seth Forshee Acked-by: Stefan Bader --- fs/shiftfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/shiftfs.c b/fs/shiftfs.c index 400c3062365c..57e04a02d74c 100644 --- a/fs/shiftfs.c +++ b/fs/shiftfs.c @@ -2102,7 +2102,7 @@ static int __init shiftfs_init(void) { shiftfs_file_info_cache = kmem_cache_create( "shiftfs_file_info_cache", sizeof(struct shiftfs_file_info), 0, - SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL); + SLAB_RECLAIM_ACCOUNT | SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL); if (!shiftfs_file_info_cache) return -ENOMEM;