[SRU,Disco] UBUNTU: SAUCE: shiftfs: mark slab objects SLAB_RECLAIM_ACCOUNT
diff mbox series

Message ID 20190830121431.8498-1-christian.brauner@ubuntu.com
State New
Headers show
Series
  • [SRU,Disco] UBUNTU: SAUCE: shiftfs: mark slab objects SLAB_RECLAIM_ACCOUNT
Related show

Commit Message

Christian Brauner Aug. 30, 2019, 12:14 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1842059

Shiftfs does not mark it's slab cache as reclaimable. While this is not
a big deal it is not nice to the kernel in general. The shiftfs cache is
not so important that it can't be reclaimed.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---
 fs/shiftfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Seth Forshee Aug. 30, 2019, 5:06 p.m. UTC | #1
On Fri, Aug 30, 2019 at 02:14:31PM +0200, Christian Brauner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1842059
> 
> Shiftfs does not mark it's slab cache as reclaimable. While this is not
> a big deal it is not nice to the kernel in general. The shiftfs cache is
> not so important that it can't be reclaimed.
> 
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Acked-by: Seth Forshee <seth.forshee@canonical.com>

Again, please remember to submit these for the development release too.
Applied to eoan/master-next and unstable/master, thanks!
Stefan Bader Sept. 25, 2019, 8:20 a.m. UTC | #2
On 30.08.19 14:14, Christian Brauner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1842059
> 
> Shiftfs does not mark it's slab cache as reclaimable. While this is not
> a big deal it is not nice to the kernel in general. The shiftfs cache is
> not so important that it can't be reclaimed.
> 
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  fs/shiftfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/shiftfs.c b/fs/shiftfs.c
> index 400c3062365c..57e04a02d74c 100644
> --- a/fs/shiftfs.c
> +++ b/fs/shiftfs.c
> @@ -2102,7 +2102,7 @@ static int __init shiftfs_init(void)
>  {
>  	shiftfs_file_info_cache = kmem_cache_create(
>  		"shiftfs_file_info_cache", sizeof(struct shiftfs_file_info), 0,
> -		SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL);
> +		SLAB_RECLAIM_ACCOUNT | SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL);
>  	if (!shiftfs_file_info_cache)
>  		return -ENOMEM;
>  
>
Kleber Souza Sept. 27, 2019, 12:34 p.m. UTC | #3
On 30.08.19 14:14, Christian Brauner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1842059
> 
> Shiftfs does not mark it's slab cache as reclaimable. While this is not
> a big deal it is not nice to the kernel in general. The shiftfs cache is
> not so important that it can't be reclaimed.
> 
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> ---
>  fs/shiftfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/shiftfs.c b/fs/shiftfs.c
> index 400c3062365c..57e04a02d74c 100644
> --- a/fs/shiftfs.c
> +++ b/fs/shiftfs.c
> @@ -2102,7 +2102,7 @@ static int __init shiftfs_init(void)
>  {
>  	shiftfs_file_info_cache = kmem_cache_create(
>  		"shiftfs_file_info_cache", sizeof(struct shiftfs_file_info), 0,
> -		SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL);
> +		SLAB_RECLAIM_ACCOUNT | SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL);
>  	if (!shiftfs_file_info_cache)
>  		return -ENOMEM;
>  
> 

Applied to disco/master-next branch.

Thanks,
Kleber

Patch
diff mbox series

diff --git a/fs/shiftfs.c b/fs/shiftfs.c
index 400c3062365c..57e04a02d74c 100644
--- a/fs/shiftfs.c
+++ b/fs/shiftfs.c
@@ -2102,7 +2102,7 @@  static int __init shiftfs_init(void)
 {
 	shiftfs_file_info_cache = kmem_cache_create(
 		"shiftfs_file_info_cache", sizeof(struct shiftfs_file_info), 0,
-		SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL);
+		SLAB_RECLAIM_ACCOUNT | SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL);
 	if (!shiftfs_file_info_cache)
 		return -ENOMEM;