Patchwork MAINTAINERS: update maintainer for target-arm and ARM devboards

login
register
mail settings
Submitter Peter Maydell
Date Sept. 20, 2011, 3:18 p.m.
Message ID <1316531926-31900-1-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/115575/
State New
Headers show

Comments

Peter Maydell - Sept. 20, 2011, 3:18 p.m.
Add myself as co-maintainer alongside Paul Brook for the TCG ARM
guest implementation (target-arm) and the ARM dev boards (integratorcp,
realview, stellaris, versatilepb).

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 MAINTAINERS |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
Anthony Liguori - Sept. 20, 2011, 3:25 p.m.
On 09/20/2011 10:18 AM, Peter Maydell wrote:
> Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> guest implementation (target-arm) and the ARM dev boards (integratorcp,
> realview, stellaris, versatilepb).
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>

Acked-by: Anthony Liguori <aliguori@us.ibm.com>

Paul, speak now or forever hold your peace ;-)

Regards,

Anthony Liguori

> ---
>   MAINTAINERS |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 72b2099..b2369c2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -62,6 +62,7 @@ F: target-alpha/
>
>   ARM
>   M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
>   S: Maintained
>   F: target-arm/
>
> @@ -168,6 +169,7 @@ F: hw/gumstix.c
>
>   Integrator CP
>   M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
>   S: Maintained
>   F: hw/integratorcp.c
>
> @@ -193,6 +195,7 @@ F: hw/palm.c
>
>   Real View
>   M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
>   S: Maintained
>   F: hw/realview*
>
> @@ -203,11 +206,13 @@ F: hw/spitz.c
>
>   Stellaris
>   M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
>   S: Maintained
>   F: hw/stellaris.c
>
>   Versatile PB
>   M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
>   S: Maintained
>   F: hw/versatilepb.c
>
Edgar Iglesias - Sept. 20, 2011, 4:52 p.m.
On Tue, Sep 20, 2011 at 04:18:46PM +0100, Peter Maydell wrote:
> Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> guest implementation (target-arm) and the ARM dev boards (integratorcp,
> realview, stellaris, versatilepb).
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Juan Quintela - Sept. 20, 2011, 6:24 p.m.
Peter Maydell <peter.maydell@linaro.org> wrote:
> Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> guest implementation (target-arm) and the ARM dev boards (integratorcp,
> realview, stellaris, versatilepb).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Acked-by: Juan Quintela <quintela@redhat.com>
Paul Brook - Sept. 20, 2011, 9:39 p.m.
> > Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> > guest implementation (target-arm) and the ARM dev boards (integratorcp,
> > realview, stellaris, versatilepb).
> > 
> > Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> 
> Acked-by: Anthony Liguori <aliguori@us.ibm.com>
> 
> Paul, speak now or forever hold your peace ;-)

I approve in general principle, and haven't being paying enough attention to 
make a specific technical judgement.

For the record I consider having multiple maintainers to be a good thing.

IMO the role of a maintainer should be to make sure sub-par code is brought up 
up to standard before it is comitted.  Approving patches is easy, rejecting 
the bad patches[1] is where you add value.  Maintainership is more an 
indication that you're competent to review those bits of code than a grant of 
control.

Paul

[1] With constructive criticism on how to fix the problem.
Anthony Liguori - Sept. 23, 2011, 6:51 p.m.
On 09/20/2011 10:18 AM, Peter Maydell wrote:
> Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> guest implementation (target-arm) and the ARM dev boards (integratorcp,
> realview, stellaris, versatilepb).
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   MAINTAINERS |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 72b2099..b2369c2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -62,6 +62,7 @@ F: target-alpha/
>
>   ARM
>   M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
>   S: Maintained
>   F: target-arm/
>
> @@ -168,6 +169,7 @@ F: hw/gumstix.c
>
>   Integrator CP
>   M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
>   S: Maintained
>   F: hw/integratorcp.c
>
> @@ -193,6 +195,7 @@ F: hw/palm.c
>
>   Real View
>   M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
>   S: Maintained
>   F: hw/realview*
>
> @@ -203,11 +206,13 @@ F: hw/spitz.c
>
>   Stellaris
>   M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
>   S: Maintained
>   F: hw/stellaris.c
>
>   Versatile PB
>   M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
>   S: Maintained
>   F: hw/versatilepb.c
>

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 72b2099..b2369c2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -62,6 +62,7 @@  F: target-alpha/
 
 ARM
 M: Paul Brook <paul@codesourcery.com>
+M: Peter Maydell <peter.maydell@linaro.org>
 S: Maintained
 F: target-arm/
 
@@ -168,6 +169,7 @@  F: hw/gumstix.c
 
 Integrator CP
 M: Paul Brook <paul@codesourcery.com>
+M: Peter Maydell <peter.maydell@linaro.org>
 S: Maintained
 F: hw/integratorcp.c
 
@@ -193,6 +195,7 @@  F: hw/palm.c
 
 Real View
 M: Paul Brook <paul@codesourcery.com>
+M: Peter Maydell <peter.maydell@linaro.org>
 S: Maintained
 F: hw/realview*
 
@@ -203,11 +206,13 @@  F: hw/spitz.c
 
 Stellaris
 M: Paul Brook <paul@codesourcery.com>
+M: Peter Maydell <peter.maydell@linaro.org>
 S: Maintained
 F: hw/stellaris.c
 
 Versatile PB
 M: Paul Brook <paul@codesourcery.com>
+M: Peter Maydell <peter.maydell@linaro.org>
 S: Maintained
 F: hw/versatilepb.c