Patchwork [U-Boot] km/common: fix bug in IVM mac address access

login
register
mail settings
Submitter Holger Brunck
Date Sept. 20, 2011, 3:05 p.m.
Message ID <1316531155-4638-1-git-send-email-holger.brunck@keymile.com>
Download mbox | patch
Permalink /patch/115568/
State Accepted
Commit 6478021f12db3e248b8b495dde02c51d05a38054
Headers show

Comments

Holger Brunck - Sept. 20, 2011, 3:05 p.m.
The MAC address stored in the inventory eeprom begins at offset 1.

Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
cc: Wolfgang Denk <wd@denx.de>
---
 board/keymile/common/ivm.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Wolfgang Denk - Sept. 21, 2011, 9:38 p.m.
Dear Holger Brunck,

In message <1316531155-4638-1-git-send-email-holger.brunck@keymile.com> you wrote:
> The MAC address stored in the inventory eeprom begins at offset 1.
> 
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> cc: Wolfgang Denk <wd@denx.de>
> ---
>  board/keymile/common/ivm.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/board/keymile/common/ivm.c b/board/keymile/common/ivm.c
index db07004..70d7845 100644
--- a/board/keymile/common/ivm.c
+++ b/board/keymile/common/ivm.c
@@ -206,8 +206,8 @@  static int ivm_analyze_block2(unsigned char *buf, int len)
 	unsigned char	valbuf[CONFIG_SYS_IVM_EEPROM_PAGE_LEN];
 	unsigned long	count;
 
-	/* IVM_MacAddress */
-	sprintf((char *)valbuf, "%pM", buf);
+	/* IVM_MAC Adress begins at offset 1 */
+	sprintf((char *)valbuf, "%pM", buf + 1);
 	ivm_set_value("IVM_MacAddress", (char *)valbuf);
 	/* if an offset is defined, add it */
 #if defined(CONFIG_PIGGY_MAC_ADRESS_OFFSET)