net/if-mtu-change.sh: set longer timeout
diff mbox series

Message ID 20190829183110.23231-1-pvorel@suse.cz
State Superseded
Delegated to: Petr Vorel
Headers show
Series
  • net/if-mtu-change.sh: set longer timeout
Related show

Commit Message

Petr Vorel Aug. 29, 2019, 6:31 p.m. UTC
Default CHANGE_INTERVAL 5s caused test to be killed after introducing
LTP_TIMEOUT_MUL to shell API.

TODO: set LTP_TIMEOUT_MUL based on CHANGE_INTERVAL.

Fixes: fbea02ab5 ("lib/tst_test.sh: setup timeout per test run for the
shell tests")

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/network/stress/interface/if-mtu-change.sh | 2 ++
 1 file changed, 2 insertions(+)

Comments

Petr Vorel Aug. 30, 2019, 8:54 a.m. UTC | #1
Hi,

> Default CHANGE_INTERVAL 5s caused test to be killed after introducing
> LTP_TIMEOUT_MUL to shell API.

> TODO: set LTP_TIMEOUT_MUL based on CHANGE_INTERVAL.

> Fixes: fbea02ab5 ("lib/tst_test.sh: setup timeout per test run for the
> shell tests")

> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/network/stress/interface/if-mtu-change.sh | 2 ++
>  1 file changed, 2 insertions(+)

> diff --git a/testcases/network/stress/interface/if-mtu-change.sh b/testcases/network/stress/interface/if-mtu-change.sh
> index 30c013214..5a05e99c9 100755
> --- a/testcases/network/stress/interface/if-mtu-change.sh
> +++ b/testcases/network/stress/interface/if-mtu-change.sh
> @@ -5,6 +5,8 @@
>  # Copyright (c) International Business Machines  Corp., 2005
>  # Author: Mitsuru Chinen <mitch@jp.ibm.com>

> +LTP_TIMEOUT_MUL=${LTP_TIMEOUT_MUL:-2}
This should wait, till we find a solution for int vs. float for shell [1]
And check if user's value is not lower than minimal (2), as Li suggested in [1].

Kind regards,
Petr

[1] https://patchwork.ozlabs.org/patch/1155460/#2250198

Patch
diff mbox series

diff --git a/testcases/network/stress/interface/if-mtu-change.sh b/testcases/network/stress/interface/if-mtu-change.sh
index 30c013214..5a05e99c9 100755
--- a/testcases/network/stress/interface/if-mtu-change.sh
+++ b/testcases/network/stress/interface/if-mtu-change.sh
@@ -5,6 +5,8 @@ 
 # Copyright (c) International Business Machines  Corp., 2005
 # Author: Mitsuru Chinen <mitch@jp.ibm.com>
 
+LTP_TIMEOUT_MUL=${LTP_TIMEOUT_MUL:-2}
+
 IF_CMD='ifconfig'
 TST_SETUP="do_setup"
 TST_CLEANUP="do_cleanup"