Patchwork add missing cmdset field in PXA3xx NAND code

login
register
mail settings
Submitter Daniel Mack
Date Dec. 1, 2008, 11:57 a.m.
Message ID <20081201115757.GA14755@buzzloop.caiaq.de>
Download mbox | patch
Permalink /patch/11551/
State New, archived
Headers show

Comments

Daniel Mack - Dec. 1, 2008, 11:57 a.m.
This adds a missing .cmdset parameter for STM 2G NAND chip
definition. Even though support for built-in NAND chips is
marked deprecated, the driver crashes in __readid() due to a NULL
pointer dereference if it's not there.

Signed-off-by: Daniel Mack <daniel@caiaq.de>
Eric Miao - Dec. 1, 2008, 1 p.m.
On Mon, Dec 1, 2008 at 7:57 PM, Daniel Mack <daniel@caiaq.de> wrote:
> This adds a missing .cmdset parameter for STM 2G NAND chip
> definition. Even though support for built-in NAND chips is
> marked deprecated, the driver crashes in __readid() due to a NULL
> pointer dereference if it's not there.
>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>

Thanks, however this is a bit later, some one spotted this earlier:

http://lists.infradead.org/pipermail/linux-mtd/2008-November/023643.html

Patch

diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index c0fa9c9..ff4d28e 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -269,6 +269,7 @@  static struct pxa3xx_nand_timing stm2GbX16_timing = {
 
 static struct pxa3xx_nand_flash stm2GbX16 = {
        .timing = &stm2GbX16_timing,
+       .cmdset = &largepage_cmdset,
        .page_per_block = 64,
        .page_size = 2048,
        .flash_width = 16,