| Message ID | 20190828195609.4176-1-peter.vernia@gmail.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | pinctrl-mcp23s08: Fix property-name in dt-example | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On středa 28. srpna 2019 21:56:09 CEST, Peter Vernia wrote: > The device-tree properties documentation-file specifies the property > "microchip,spi-present-mask" as required for MCP23SXX chips. However, > the device-tree-source example below it uses only "spi-present-mask". > Without "microchip," on the front, the driver will print "missing > spi-present-mask" when it initializes. > > Update the device-tree example with the correct property-name. > > Signed-off-by: Peter Vernia <peter.vernia@gmail.com> Reviewed-by: Jan Kundrát <jan.kundrat@cesnet.cz> > --- > Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt > b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt > index 625a22e2f211..8b94aa8f5971 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt > @@ -82,7 +82,7 @@ gpiom1: gpio@0 { > compatible = "microchip,mcp23s17"; > gpio-controller; > #gpio-cells = <2>; > - spi-present-mask = <0x01>; > + microchip,spi-present-mask = <0x01>; > reg = <0>; > spi-max-frequency = <1000000>; > };
On Wed, 28 Aug 2019 15:56:09 -0400, Peter Vernia wrote: > The device-tree properties documentation-file specifies the property > "microchip,spi-present-mask" as required for MCP23SXX chips. However, > the device-tree-source example below it uses only "spi-present-mask". > Without "microchip," on the front, the driver will print "missing > spi-present-mask" when it initializes. > > Update the device-tree example with the correct property-name. > > Signed-off-by: Peter Vernia <peter.vernia@gmail.com> > --- > Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. Rob
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt index 625a22e2f211..8b94aa8f5971 100644 --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt @@ -82,7 +82,7 @@ gpiom1: gpio@0 { compatible = "microchip,mcp23s17"; gpio-controller; #gpio-cells = <2>; - spi-present-mask = <0x01>; + microchip,spi-present-mask = <0x01>; reg = <0>; spi-max-frequency = <1000000>; };
The device-tree properties documentation-file specifies the property "microchip,spi-present-mask" as required for MCP23SXX chips. However, the device-tree-source example below it uses only "spi-present-mask". Without "microchip," on the front, the driver will print "missing spi-present-mask" when it initializes. Update the device-tree example with the correct property-name. Signed-off-by: Peter Vernia <peter.vernia@gmail.com> --- Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)