[1/1,SRU,E] UBUNTU: SAUCE: drm/i915/fbc: disable framebuffer compression on IceLake
diff mbox series

Message ID 20190828074000.15455-2-vicamo.yang@canonical.com
State New
Headers show
Series
  • drm/i915/fbc: disable framebuffer compression on IceLake
Related show

Commit Message

You-Sheng Yang Aug. 28, 2019, 7:40 a.m. UTC
This is the same thing to commit
edf87a92e112ede83916155a156e41787ea11186 but found on IceLake platforms
as well.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111484
Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
---
 drivers/gpu/drm/i915/intel_fbc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Seth Forshee Aug. 30, 2019, 4:30 p.m. UTC | #1
On Wed, Aug 28, 2019 at 03:40:00PM +0800, You-Sheng Yang wrote:
> This is the same thing to commit
> edf87a92e112ede83916155a156e41787ea11186 but found on IceLake platforms
> as well.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111484
> Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>

What kind of testing has been done with this patch? Can we also have a
bug in launchpad please?

Thanks,
Seth
You-Sheng Yang Sept. 2, 2019, 12:22 p.m. UTC | #2
Hi Seth,

I sent another revision to include launchpad bug link in the patch as
well. This patch targets pre-launch ICL platforms and has been verified
on them.

You-Sheng Yang

On 2019/8/31 12:30 AM, Seth Forshee wrote:
> On Wed, Aug 28, 2019 at 03:40:00PM +0800, You-Sheng Yang wrote:
>> This is the same thing to commit
>> edf87a92e112ede83916155a156e41787ea11186 but found on IceLake platforms
>> as well.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111484
>> Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
> 
> What kind of testing has been done with this patch? Can we also have a
> bug in launchpad please?
> 
> Thanks,
> Seth
>

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 5679f2fffb7c7..7d44f79c2ea46 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -1281,7 +1281,8 @@  static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
 		return 0;
 
 	/* https://bugs.freedesktop.org/show_bug.cgi?id=108085 */
-	if (IS_GEMINILAKE(dev_priv))
+	/* https://bugs.freedesktop.org/show_bug.cgi?id=111484 */
+	if (IS_GEMINILAKE(dev_priv) || IS_ICELAKE(dev_priv))
 		return 0;
 
 	if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9)