| Message ID | 20190827173432.7656-1-nsoffer@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | iotests: Unify cache mode quoting | expand |
On 27.08.19 19:34, Nir Soffer wrote: > Quoting cache mode is not needed, and most tests use unquoted values. > Unify all test to use the same style. S-o-b is missing, shall I add it? Max > --- > tests/qemu-iotests/026 | 4 ++-- > tests/qemu-iotests/039 | 4 ++-- > tests/qemu-iotests/052 | 2 +- > tests/qemu-iotests/091 | 4 ++-- > 4 files changed, 7 insertions(+), 7 deletions(-)
On Tue, Aug 27, 2019 at 8:36 PM Max Reitz <mreitz@redhat.com> wrote: > On 27.08.19 19:34, Nir Soffer wrote: > > Quoting cache mode is not needed, and most tests use unquoted values. > > Unify all test to use the same style. > > S-o-b is missing, shall I add it? > Thanks! Signed-off-by: Nir Soffer <nsoffer@redhat.com> > > Max > > > --- > > tests/qemu-iotests/026 | 4 ++-- > > tests/qemu-iotests/039 | 4 ++-- > > tests/qemu-iotests/052 | 2 +- > > tests/qemu-iotests/091 | 4 ++-- > > 4 files changed, 7 insertions(+), 7 deletions(-) > >
On 27.08.19 19:38, Nir Soffer wrote: > On Tue, Aug 27, 2019 at 8:36 PM Max Reitz <mreitz@redhat.com > <mailto:mreitz@redhat.com>> wrote: > > On 27.08.19 19:34, Nir Soffer wrote: > > Quoting cache mode is not needed, and most tests use unquoted values. > > Unify all test to use the same style. > > S-o-b is missing, shall I add it? > > > Thanks! > > Signed-off-by: Nir Soffer <nsoffer@redhat.com> Thanks, applied to my block branch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block (By the way, did you set your author email address to an @gmail address on purpose?) Max
On Tue, Aug 27, 2019 at 8:43 PM Max Reitz <mreitz@redhat.com> wrote: > > On 27.08.19 19:38, Nir Soffer wrote: > > On Tue, Aug 27, 2019 at 8:36 PM Max Reitz <mreitz@redhat.com > > <mailto:mreitz@redhat.com>> wrote: > > > > On 27.08.19 19:34, Nir Soffer wrote: > > > Quoting cache mode is not needed, and most tests use unquoted values. > > > Unify all test to use the same style. > > > > S-o-b is missing, shall I add it? > > > > > > Thanks! > > > > Signed-off-by: Nir Soffer <nsoffer@redhat.com> > > Thanks, applied to my block branch: > > https://git.xanclic.moe/XanClic/qemu/commits/branch/block > > (By the way, did you set your author email address to an @gmail address > on purpose?) I configured my gmail address nowhere, I think this is a side affect of using gmail to send the patches. > > Max >
Patchew URL: https://patchew.org/QEMU/20190827173432.7656-1-nsoffer@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190827173432.7656-1-nsoffer@redhat.com Type: series Subject: [Qemu-devel] [PATCH] iotests: Unify cache mode quoting === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' f682fe9 iotests: Unify cache mode quoting === OUTPUT BEGIN === ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 38 lines checked Commit f682fe9cf33c (iotests: Unify cache mode quoting) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190827173432.7656-1-nsoffer@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
diff --git a/tests/qemu-iotests/026 b/tests/qemu-iotests/026 index e30243608b..ffb18ab6b5 100755 --- a/tests/qemu-iotests/026 +++ b/tests/qemu-iotests/026 @@ -41,8 +41,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 # Currently only qcow2 supports rebasing _supported_fmt qcow2 _supported_proto file -_default_cache_mode "writethrough" -_supported_cache_modes "writethrough" "none" +_default_cache_mode writethrough +_supported_cache_modes writethrough none # The refcount table tests expect a certain minimum width for refcount entries # (so that the refcount table actually needs to grow); that minimum is 16 bits, # being the default refcount entry width. diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039 index 0d4e963bd4..7c730d94a7 100755 --- a/tests/qemu-iotests/039 +++ b/tests/qemu-iotests/039 @@ -42,8 +42,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 _supported_fmt qcow2 _supported_proto file _supported_os Linux -_default_cache_mode "writethrough" -_supported_cache_modes "writethrough" +_default_cache_mode writethrough +_supported_cache_modes writethrough size=128M diff --git a/tests/qemu-iotests/052 b/tests/qemu-iotests/052 index 6e2ecbfe21..45a140910d 100755 --- a/tests/qemu-iotests/052 +++ b/tests/qemu-iotests/052 @@ -40,7 +40,7 @@ _supported_fmt generic _supported_proto file # Don't do O_DIRECT on tmpfs -_supported_cache_modes "writeback" "writethrough" "unsafe" +_supported_cache_modes writeback writethrough unsafe size=128M _make_test_img $size diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091 index d62ef18a02..f4b44659ae 100755 --- a/tests/qemu-iotests/091 +++ b/tests/qemu-iotests/091 @@ -46,8 +46,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 _supported_fmt qcow2 _supported_proto file _supported_os Linux -_default_cache_mode "none" -_supported_cache_modes "writethrough" "none" "writeback" +_default_cache_mode none +_supported_cache_modes writethrough none writeback size=1G