From patchwork Tue Aug 27 03:55:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Winter X-Patchwork-Id: 1153664 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=alliedtelesis.co.nz Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KVARG7FI"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="00mjYcp/"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46Hjf16KKVz9s00 for ; Tue, 27 Aug 2019 19:06:01 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S8fkd4DZCfcOMGlhnbvheHfGoksrQcLG5aOA7bIPm0w=; b=KVARG7FIwlx57d efAGKm9Z2VC1SCv6HqaATN0kwMJaOzwRPJRMLEqfzoTIDqA7PunwCBBKo00Tn1LyfffyRUlx82jnu L5ZAw0PUNxilE/Czi2nQFxcbN+BIOxlgrkZD/IC89Fd1c1/gfFkRFLlvBvvw60wl9JP092DbuTdWe 5KXcPjMTqetAhvASoo2WGGyDOgXZwE7piYBi8fSDP5Sq27Fl7IhvtdYVakeh2BnjwqESmmlsoxnlR +KdQ5xx8fsOnovjlOL4bWLflgn/iUDIfEWZ5sm53MZ9F6wriyoa84OFSEbFelCMiSr/KeWX0fed+q vOTtQkD7YcWU+OBZxhlg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2XQN-0002Xl-GY; Tue, 27 Aug 2019 09:05:59 +0000 Received: from gate2.alliedtelesis.co.nz ([2001:df5:b000:5::4]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2Sb1-0007lH-8P for hostap@lists.infradead.org; Tue, 27 Aug 2019 03:56:40 +0000 Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id D43E0891A9 for ; Tue, 27 Aug 2019 15:56:24 +1200 (NZST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1566878184; bh=JkeZWGRc+YZdysVUdWzxJRC+5SkNaHgcXNxurKBJuzE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=00mjYcp/TuzThYbktW8f9P0FTgxhGwXJMXOhTH/vdn6QKHaAb76tYaVxrrJFxNbKi z7aW8ONzr1L+R04v6A9S4ZbPEbileYcSYo2lrwzePX67Xwlu5Ml+W9pTGfbRF2ur5Q +gXzhvz9NcEjwSVKlYcm4fR/3r8WbSTmf/XBcglwPzLClHSdk3AHpPa7/gU2OuRMQW VcwxH/cz/sDs+38g+eXPefNtxEoZNYxjne9kyd/57bwDrVAe/WGaIycH3IEc6tzoCK 8I09YPG0YoqV/VT37/FMi8u1OqVsgP4HC4ZAYTBjZ2vIouxJ4H/261OXdFyKuML7hj dQrLzW9Wfywiw== Received: from smtp (Not Verified[10.32.16.33]) by mmarshal3.atlnz.lc with Trustwave SEG (v7, 5, 8, 10121) id ; Tue, 27 Aug 2019 15:56:22 +1200 Received: from thomaswi-dl.ws.atlnz.lc (thomaswi-dl.ws.atlnz.lc [10.33.12.31]) by smtp (Postfix) with ESMTP id 561AC13EF9B; Tue, 27 Aug 2019 15:56:27 +1200 (NZST) Received: by thomaswi-dl.ws.atlnz.lc (Postfix, from userid 1719) id 57292440046; Tue, 27 Aug 2019 15:56:24 +1200 (NZST) From: Thomas Winter To: hostap@lists.infradead.org Subject: [PATCH 2/5] mka: Don't set newSAK to FALSE on ABANDON Date: Tue, 27 Aug 2019 15:55:35 +1200 Message-Id: <4ab872861dcdfd4b67074661fff0ebe64710ff9e.1566876816.git.Thomas.Winter@alliedtelesis.co.nz> X-Mailer: git-send-email 2.23.0 In-Reply-To: References: MIME-Version: 1.0 x-atlnz-ls: pat X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190826_205639_510091_790C4B83 X-CRM114-Status: GOOD ( 10.27 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-Mailman-Approved-At: Tue, 27 Aug 2019 02:05:47 -0700 X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Winter Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Previously the ABANDON->RECEIVE state change was impossible and did not match the CP state machine in IEEE 802.1X-2010 Figure 12-2. Signed-off-by: Thomas Winter --- src/pae/ieee802_1x_cp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/pae/ieee802_1x_cp.c b/src/pae/ieee802_1x_cp.c index ab6abda24..a19f07518 100644 --- a/src/pae/ieee802_1x_cp.c +++ b/src/pae/ieee802_1x_cp.c @@ -301,7 +301,6 @@ SM_STATE(CP, ABANDON) sm->lki = NULL; ieee802_1x_kay_set_latest_sa_attr(sm->kay, sm->lki, sm->lan, sm->ltx, sm->lrx); - sm->new_sak = FALSE; }