wpa_supplicant: Don't return an error when successfully parsing wmm rules
diff mbox series

Message ID 64AA02D3-9F1F-411D-8921-DC99F8D0C393@eero.com
State Accepted
Headers show
Series
  • wpa_supplicant: Don't return an error when successfully parsing wmm rules
Related show

Commit Message

Sujay Patwardhan Aug. 26, 2019, 6:35 p.m. UTC
The config file parser previously would fall through into an error if CONFIG_AP is defined and it hit a wmm_ac_* rule. This commit adds a return to prevent incorrectly printing an error message and returning a non-zero exit code.

Signed-off-by: Sujay Patwardhan <sujay@eero.com>
---
 wpa_supplicant/config.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jouni Malinen Sept. 13, 2019, 2:26 p.m. UTC | #1
On Mon, Aug 26, 2019 at 11:35:38AM -0700, Sujay Patwardhan wrote:
> The config file parser previously would fall through into an error if CONFIG_AP is defined and it hit a wmm_ac_* rule. This commit adds a return to prevent incorrectly printing an error message and returning a non-zero exit code.

Thanks, applied.

Patch
diff mbox series

diff --git a/wpa_supplicant/config.c b/wpa_supplicant/config.c
index 7a62f96..8e94e94 100644
--- a/wpa_supplicant/config.c
+++ b/wpa_supplicant/config.c
@@ -4987,6 +4987,7 @@  int wpa_config_process_global(struct wpa_config *config, char *pos, int line)
 					   "AC item", line);
 				return -1;
 			}
+			return ret;
 		}
 #endif /* CONFIG_AP */
 		if (line < 0)