diff mbox series

[U-Boot,PATCHv2] armv8: fsl-layerscape: Fix a typo of Layerscape PCIe config entry

Message ID 20190826083820.30909-1-Zhiqiang.Hou@nxp.com
State Superseded
Delegated to: Prabhakar Kushwaha
Headers show
Series [U-Boot,PATCHv2] armv8: fsl-layerscape: Fix a typo of Layerscape PCIe config entry | expand

Commit Message

Z.Q. Hou Aug. 26, 2019, 8:36 a.m. UTC 
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

The correct config entry is CONFIG_PCIE_LAYERSCAPE, this typo
result in skipping the fixup of Linux PCIe DT nodes.

Also enable the fixup when Layerscape Gen4 controller driver
is enabled.

Fixes: 4da0e52c9dc0 (armv8: fsl-layerscape: fix config dependency for layerscape pci code)
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
---
V2:
 - Enable this fixup for Layerscape Gen4 controller driver.

 arch/arm/cpu/armv8/fsl-layerscape/fdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bin Meng Aug. 26, 2019, 8:55 a.m. UTC | #1 
On Mon, Aug 26, 2019 at 4:36 PM Z.q. Hou <zhiqiang.hou@nxp.com> wrote:
>
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>
> The correct config entry is CONFIG_PCIE_LAYERSCAPE, this typo

nits: and this typo

> result in skipping the fixup of Linux PCIe DT nodes.

results

>
> Also enable the fixup when Layerscape Gen4 controller driver
> is enabled.
>
> Fixes: 4da0e52c9dc0 (armv8: fsl-layerscape: fix config dependency for layerscape pci code)
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---
> V2:
>  - Enable this fixup for Layerscape Gen4 controller driver.
>
>  arch/arm/cpu/armv8/fsl-layerscape/fdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

After addressing the above, you can add my:
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Regards,
Bin
Z.Q. Hou Aug. 26, 2019, 10 a.m. UTC | #2 
Hi Bin,

Thanks a lot for your comments!

> -----Original Message-----
> From: Bin Meng <bmeng.cn@gmail.com>
> Sent: 2019年8月26日 16:56
> To: Z.q. Hou <zhiqiang.hou@nxp.com>
> Cc: u-boot@lists.denx.de; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; alexm.osslist@gmail.com
> Subject: Re: [U-Boot] [PATCHv2] armv8: fsl-layerscape: Fix a typo of
> Layerscape PCIe config entry
> 
> On Mon, Aug 26, 2019 at 4:36 PM Z.q. Hou <zhiqiang.hou@nxp.com> wrote:
> >
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > The correct config entry is CONFIG_PCIE_LAYERSCAPE, this typo
> 
> nits: and this typo
> 
> > result in skipping the fixup of Linux PCIe DT nodes.
> 
> results

I'll fix my bad sentence in v3 :).

> >
> > Also enable the fixup when Layerscape Gen4 controller driver is
> > enabled.
> >
> > Fixes: 4da0e52c9dc0 (armv8: fsl-layerscape: fix config dependency for
> > layerscape pci code)
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> > V2:
> >  - Enable this fixup for Layerscape Gen4 controller driver.
> >
> >  arch/arm/cpu/armv8/fsl-layerscape/fdt.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> 
> After addressing the above, you can add my:
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Thanks a lot for your review!

B.R,
Zhiqiang

> Regards,
> Bin
diff mbox series

Patch

diff --git a/arch/arm/cpu/armv8/fsl-layerscape/fdt.c b/arch/arm/cpu/armv8/fsl-layerscape/fdt.c
index fabe0f0359..25b7afe064 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/fdt.c
+++ b/arch/arm/cpu/armv8/fsl-layerscape/fdt.c
@@ -435,7 +435,7 @@  void ft_cpu_setup(void *blob, bd_t *bd)
 	do_fixup_by_path_u32(blob, "/sysclk", "clock-frequency",
 			     CONFIG_SYS_CLK_FREQ, 1);
 
-#ifdef CONFIG_PCI_LAYERSCAPE
+#if defined(CONFIG_PCIE_LAYERSCAPE) || defined(CONFIG_PCIE_LAYERSCAPE_GEN4)
 	ft_pci_setup(blob, bd);
 #endif