From patchwork Sat Aug 24 12:00:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 1152588 X-Patchwork-Delegate: tudor.ambarus@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=microchip.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e6ux0h4b"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="Ht5Jx/2G"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46Fxgn5VCgz9sN1 for ; Sat, 24 Aug 2019 22:01:25 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MYLGrzYG6aVRQaJ/fd+F3SZzWq4kAz7j4nx/0MEOwQU=; b=e6ux0h4bxacVO0 9w1p7+cKvMv3uzgPR1t81p6LBz4q7RcWDAF2y5ZZUr7Dzkdorxd34M+UcrZwJwP+vGEWiWwHxoDJP 0MYeiebVZrhU6vVN6nuvO3kEzp0nX2VtSW9m47/HyLhXKNgVXPtpoPasw1sWf6yH3uScvCZ+Z6tcr SzqZ3bJZUoGQ+o7lhdLrRj/Claf4PQxbApnBO1o9eOovKzhGIZjMcF0HX6bx5Db6TvVzG928/mKUA XV4/nDN/gC4nLzF5fvO0BOPJEClTUVwQMo8LrWsdKu6WuV42aWhEhdXg6+I34uSwGqDMMRwyTkWWF 0hVP1ScowKOashF847+Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i1UjT-0001aa-8x; Sat, 24 Aug 2019 12:01:23 +0000 Received: from esa3.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i1Uir-0000td-I9 for linux-mtd@lists.infradead.org; Sat, 24 Aug 2019 12:00:47 +0000 Received-SPF: Pass (esa3.microchip.iphmx.com: domain of Tudor.Ambarus@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa3.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="Tudor.Ambarus@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com a:mx1.microchip.iphmx.com a:mx2.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa3.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa3.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa3.microchip.iphmx.com; spf=Pass smtp.mailfrom=Tudor.Ambarus@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: 1g5oRSSztCEo9Rvr8SFS92XStYUdDAHy60Q3MGI80VOxlcxtVQlsBJdHQjJPxQvH1usU+xtMS3 8UV6iu7FkX2eJXoGbQ9NC8EmlbKhrRievkIuykpIDIWtIHNEV/i91MLtIR1arAtVCcBaDApZ6W H6AZlJK9OpzBkTxFD5Ta6xVwQbm7ctOp143mCPImseYf8n3sHV/YXm98WreQKuA6vFgnz/ERiI 1QT+K/Epn1Jpf7o9wShKm0AGxfUDEc07fKDs/U3JP6fGST6VkGXX6m9y6FIBeJH6stkkxX3Zk/ TQI= X-IronPort-AV: E=Sophos;i="5.64,425,1559545200"; d="scan'208";a="46464751" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 Aug 2019 05:00:42 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sat, 24 Aug 2019 05:00:42 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sat, 24 Aug 2019 05:00:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LVU44fflv5+hFiTLT0Pv3TM1Xaq+GFOgB757GcHj4kkKBhmDPNQera2R7qRgoO+iuZYx7N2IGgKwwqdJo0Po3klo5Sv5CUE8EGmoIwSE1vbMGj8fq2kysTkcVbtTcs5E44Y/cNXtC7UlLa+ydhB6YYfCX795plPoS1YVpG0OcEfDZ1j6wUz0C24p7NtENU8KmzLaEN3olw5FloDLVhCmbhR+7Jyrm1a15Y+ndZcmmSBHrVBr8rnSfwIgwLezMEUpQZNTniSkPMgorNq4MtsCh1x7PKq3CNYdsfERa5W/wfWQYzngQKyErbwXo2DW3m3SU0NjVEgs/RYH58SnoJfMZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vUQxNe3OAVO9rUQSyqf9kLDICbtbnGEhLBUguMYgUO8=; b=cC73qFXqbpFUpWrNST/iUyPhkR3WB5z1ExdPTKpClqkGzjU6v6IFddXlVEFepCpd5VaxKprXRiEA4nHOfcgCdioyVNcGtLjcvOi9/Ejnr7Zqw/rZT+/CJsGqmH9KJztEBrBM0XLPIXQmGwxmlsDzG30z350Hr3mLWaxPUfg9Pz5Bvu+W/5iMVbMvleBIfAVfF9qofv9oyEh0sVM1MLR6TjqLj2jxssYcDYb0BLiIamiJy2yVT9XLrW4GscE7qmSLEGGOLvfZkwjIMYJ4jFaJMR3UziPhJHX5048Y/mUlJp40gc+/TcTvbn1HlS6KcHBE9xB+KXwSPZNKZzANSjZfwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vUQxNe3OAVO9rUQSyqf9kLDICbtbnGEhLBUguMYgUO8=; b=Ht5Jx/2G7syofqiI2oJ1i6NxwfpNaCbIhoMIdoYZqPul7Jy3fMurTFLwD0x8EyOB8Cvrqjn7Wbee94UXwfld69FJ1/rbe5BEezoj/jl7NBZW40Tn3gESGcJKEQ2wqNggeayl7Be73XwQq15zqmnLcwZJhsmdlnv+5shfsXOQx70= Received: from MN2PR11MB4448.namprd11.prod.outlook.com (52.135.39.157) by MN2PR11MB3984.namprd11.prod.outlook.com (10.255.181.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.19; Sat, 24 Aug 2019 12:00:41 +0000 Received: from MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::70c3:e929:4da2:60a5]) by MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::70c3:e929:4da2:60a5%7]) with mapi id 15.20.2178.020; Sat, 24 Aug 2019 12:00:41 +0000 From: To: , , , , , , Subject: [PATCH v2 3/7] mtd: spi_nor: Move manufacturer quad_enable() in ->default_init() Thread-Topic: [PATCH v2 3/7] mtd: spi_nor: Move manufacturer quad_enable() in ->default_init() Thread-Index: AQHVWnONChlfDI2lKEuSOGQMw5/1ew== Date: Sat, 24 Aug 2019 12:00:41 +0000 Message-ID: <20190824120027.14452-4-tudor.ambarus@microchip.com> References: <20190824120027.14452-1-tudor.ambarus@microchip.com> In-Reply-To: <20190824120027.14452-1-tudor.ambarus@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR07CA0194.eurprd07.prod.outlook.com (2603:10a6:802:3f::18) To MN2PR11MB4448.namprd11.prod.outlook.com (2603:10b6:208:193::29) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.9.5 x-originating-ip: [86.127.53.184] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4e849081-9b73-4bdf-62ce-08d7288aaf98 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR11MB3984; x-ms-traffictypediagnostic: MN2PR11MB3984: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 0139052FDB x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(396003)(366004)(39860400002)(199004)(189003)(110136005)(25786009)(26005)(446003)(4326008)(1076003)(256004)(316002)(386003)(2501003)(81156014)(6506007)(8936002)(64756008)(66556008)(66476007)(66946007)(6436002)(81166006)(66446008)(8676002)(2201001)(53936002)(76176011)(5660300002)(86362001)(6512007)(52116002)(71200400001)(14454004)(11346002)(66066001)(476003)(305945005)(6486002)(36756003)(7736002)(186003)(71190400001)(478600001)(2906002)(102836004)(99286004)(50226002)(6116002)(3846002)(107886003)(486006)(2616005); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3984; H:MN2PR11MB4448.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: d0hN9q9tibo7Eh1g8hWLokCJjAOdV3jX20VgV3d0ElYDxtAZtNeO4Afev8E+u2fiNwd1iZoUfTZsbJC1MZBemBZ1AJnXR2qtQD+nktiKsGDkf3wBA18ib6QZjDPL35oqqz/xMpAC13SX9QKU2WCE+qiLD/aU5JVMDiruP6KlDEZPoq96NXQfmRA6mrQp3t4xk0i/YkNvkbJnySssgUN7YOzv66o3Q9jtDvfngUlBqVECEKB9yedzh5HA0jE0niriZC33w2BKzBMCz0ZauE/l9DBo704k7Wxn3XdHHw01g2Wfc6Zq0a1EYw7KkSml4LCL0C+JCVn57tGL+pQHZy6M5qRFgA6FnbS+dh5QxGTW0XSeC9pRkzqmgOV45/tfy6/DBsz3jLuVbxtAUXCmus6yOz6yWzLc/XGlxH2vGPy8/eA= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4e849081-9b73-4bdf-62ce-08d7288aaf98 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Aug 2019 12:00:41.4960 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: o9BHNjrBpOIxSmQdtpAAZVET95U6iFQ5PD7XZHLqg9vrQ1XZFRwMKP2XOY7Nm+9QviYVHXILvo7/k6y8bjGCrT+7r+uUK8hkCIqIqdjtBgg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3984 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190824_050045_711375_598C20A4 X-CRM114-Status: GOOD ( 10.45 ) X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [68.232.153.233 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tudor.Ambarus@microchip.com Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Tudor Ambarus The goal is to move the quad_enable manufacturer specific init in the nor->manufacturer->fixups->default_init() The legacy quad_enable() implementation is spansion_quad_enable(), select this method by default. Set specific manufacturer fixups->default_init() hooks to overwrite the default quad_enable() implementation when needed. Signed-off-by: Tudor Ambarus Reviewed-by: Boris Brezillon --- drivers/mtd/spi-nor/spi-nor.c | 48 ++++++++++++++++++++++++++----------------- 1 file changed, 29 insertions(+), 19 deletions(-) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 27951e5a01e2..c9514dfd7d6d 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -4150,13 +4150,38 @@ static int spi_nor_parse_sfdp(struct spi_nor *nor, return err; } +static void macronix_set_default_init(struct spi_nor *nor) +{ + nor->params.quad_enable = macronix_quad_enable; +} + +static void st_micron_set_default_init(struct spi_nor *nor) +{ + nor->params.quad_enable = NULL; +} + /** * spi_nor_manufacturer_init_params() - Initialize the flash's parameters and - * settings based on ->default_init() hook. + * settings based on MFR register and ->default_init() hook. * @nor: pointer to a 'struct spi-nor'. */ static void spi_nor_manufacturer_init_params(struct spi_nor *nor) { + /* Init flash parameters based on MFR */ + switch (JEDEC_MFR(nor->info)) { + case SNOR_MFR_MACRONIX: + macronix_set_default_init(nor); + break; + + case SNOR_MFR_ST: + case SNOR_MFR_MICRON: + st_micron_set_default_init(nor); + break; + + default: + break; + } + if (nor->info->fixups && nor->info->fixups->default_init) nor->info->fixups->default_init(nor); } @@ -4168,6 +4193,9 @@ static int spi_nor_init_params(struct spi_nor *nor) const struct flash_info *info = nor->info; u8 i, erase_mask; + /* Initialize legacy flash parameters and settings. */ + params->quad_enable = spansion_quad_enable; + /* Set SPI NOR sizes. */ params->size = (u64)info->sector_size * info->n_sectors; params->page_size = info->page_size; @@ -4233,24 +4261,6 @@ static int spi_nor_init_params(struct spi_nor *nor) SPINOR_OP_SE); spi_nor_init_uniform_erase_map(map, erase_mask, params->size); - /* Select the procedure to set the Quad Enable bit. */ - if (params->hwcaps.mask & (SNOR_HWCAPS_READ_QUAD | - SNOR_HWCAPS_PP_QUAD)) { - switch (JEDEC_MFR(info)) { - case SNOR_MFR_MACRONIX: - params->quad_enable = macronix_quad_enable; - break; - - case SNOR_MFR_ST: - case SNOR_MFR_MICRON: - break; - - default: - /* Kept only for backward compatibility purpose. */ - params->quad_enable = spansion_quad_enable; - break; - } - } spi_nor_manufacturer_init_params(nor);