ext4: fix punch hole for inline_data file systems
diff mbox series

Message ID 20190824023851.30991-1-tytso@mit.edu
State New
Headers show
  • ext4: fix punch hole for inline_data file systems
Related show

Commit Message

Theodore Y. Ts'o Aug. 24, 2019, 2:38 a.m. UTC
If a program attempts to punch a hole on an inline data file, we need
to convert it to a normal file first.

This was detected using ext4/032 using the adv configuration.  Simple

mke2fs -Fq -t ext4 -O inline_data /dev/vdc
mount /vdc
echo "" > /vdc/testfile
xfs_io -c 'truncate 33554432' /vdc/testfile
xfs_io -c 'fpunch 0 1048576' /vdc/testfile
umount /vdc
e2fsck -fy /dev/vdc

Cc: stable@vger.kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
 fs/ext4/inode.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff mbox series

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 2b1c58da8d1e..e567f0229d4e 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -4236,6 +4236,15 @@  int ext4_punch_hole(struct inode *inode, loff_t offset, loff_t length)
 	trace_ext4_punch_hole(inode, offset, length, 0);
+	ext4_clear_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA);
+	if (ext4_has_inline_data(inode)) {
+		down_write(&EXT4_I(inode)->i_mmap_sem);
+		ret = ext4_convert_inline_data(inode);
+		up_write(&EXT4_I(inode)->i_mmap_sem);
+		if (ret)
+			return ret;
+	}
 	 * Write out all dirty pages to avoid race conditions
 	 * Then release them.