[U-Boot,3/4] env: add missing <compiler.h> header file
diff mbox series

Message ID 1566594199-25314-4-git-send-email-pjtexier@koncepto.io
State Superseded
Headers show
Series
  • env: fix build error for envtools
Related show

Commit Message

Pierre-Jean Texier Aug. 23, 2019, 9:03 p.m. UTC
Since commit af95f20 ("env: Create a new file for environment functions"),
a new header file exists.

So, this commit add a missing header file.

Fixes:

include/env.h:158:1: error: unknown type name ‘ulong’; did you mean ‘long’?
 ulong env_get_ulong(const char *name, int base, ulong default_val);
 ^~~~~
 long
include/env.h:158:49: error: unknown type name ‘ulong’; did you mean ‘long’?
 ulong env_get_ulong(const char *name, int base, ulong default_val);

Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
---
 include/env.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Joris OFFOUGA Aug. 24, 2019, 8:50 a.m. UTC | #1
Hi Pierre-Jean

It's work on my side.

Tested-by Joris Offouga <offougajoris@gmail.com>

Best Regards,
Joris Offouga

Le ven. 23 août 2019 à 23:05, Pierre-Jean Texier <pjtexier@koncepto.io> a
écrit :

> Since commit af95f20 ("env: Create a new file for environment functions"),
> a new header file exists.
>
> So, this commit add a missing header file.
>
> Fixes:
>
> include/env.h:158:1: error: unknown type name ‘ulong’; did you mean ‘long’?
>  ulong env_get_ulong(const char *name, int base, ulong default_val);
>  ^~~~~
>  long
> include/env.h:158:49: error: unknown type name ‘ulong’; did you mean
> ‘long’?
>  ulong env_get_ulong(const char *name, int base, ulong default_val);
>
> Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> ---
>  include/env.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/env.h b/include/env.h
> index a74a261..b72239f 100644
> --- a/include/env.h
> +++ b/include/env.h
> @@ -9,6 +9,7 @@
>  #ifndef __ENV_H
>  #define __ENV_H
>
> +#include <compiler.h>
>  #include <stdbool.h>
>  #include <linux/types.h>
>
> --
> 2.7.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
>
Heiko Schocher Aug. 26, 2019, 6:57 a.m. UTC | #2
Hello Pierre-Jean,

Am 23.08.2019 um 23:03 schrieb Pierre-Jean Texier:
> Since commit af95f20 ("env: Create a new file for environment functions"),
> a new header file exists.
> 
> So, this commit add a missing header file.
> 
> Fixes:
> 
> include/env.h:158:1: error: unknown type name ‘ulong’; did you mean ‘long’?
>   ulong env_get_ulong(const char *name, int base, ulong default_val);
>   ^~~~~
>   long
> include/env.h:158:49: error: unknown type name ‘ulong’; did you mean ‘long’?
>   ulong env_get_ulong(const char *name, int base, ulong default_val);
> 
> Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> ---
>   include/env.h | 1 +
>   1 file changed, 1 insertion(+)

See the same problem, thanks for the Fix!

Tested-by: Heiko Schocher <hs@denx.de>

bye,
Heiko

Patch
diff mbox series

diff --git a/include/env.h b/include/env.h
index a74a261..b72239f 100644
--- a/include/env.h
+++ b/include/env.h
@@ -9,6 +9,7 @@ 
 #ifndef __ENV_H
 #define __ENV_H
 
+#include <compiler.h>
 #include <stdbool.h>
 #include <linux/types.h>