| Message ID | 90bd564769dbabaa7cf70b08e77170d54fa4b625.1566467963.git.tony.nguyen@bt.com |
|---|---|
| State | New |
| Headers | show |
| Series | Declare device little or big endian | expand |
On Sat, Aug 24, 2019 at 04:56:28AM +1000, Tony Nguyen wrote: > For each device declared with DEVICE_NATIVE_ENDIAN, find the set of > targets from the set of target/hw/*/device.o. > > If the set of targets are all little or all big endian, re-declare > the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN > respectively. > > This *naive* deduction may result in genuinely native endian devices > being incorrectly declared as little or big endian, but should not > introduce regressions for current targets. > > These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it > has a new target with an opposite endian or 2) someone informed knows > better =) > > Signed-off-by: Tony Nguyen <tony.nguyen@bt.com> > --- > hw/i2c/imx_i2c.c | 2 +- > hw/i2c/mpc_i2c.c | 2 +- > hw/i2c/versatile_i2c.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) ppc part (mpc_i2c.c) Acked-by: David Gibson <david@gibson.dropbear.id.au> > > diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c > index 30b9aea247..cc2689d967 100644 > --- a/hw/i2c/imx_i2c.c > +++ b/hw/i2c/imx_i2c.c > @@ -278,7 +278,7 @@ static const MemoryRegionOps imx_i2c_ops = { > .write = imx_i2c_write, > .valid.min_access_size = 1, > .valid.max_access_size = 2, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, > }; > > static const VMStateDescription imx_i2c_vmstate = { > diff --git a/hw/i2c/mpc_i2c.c b/hw/i2c/mpc_i2c.c > index 0aa1be3ce7..b71b5ff7d5 100644 > --- a/hw/i2c/mpc_i2c.c > +++ b/hw/i2c/mpc_i2c.c > @@ -306,7 +306,7 @@ static const MemoryRegionOps i2c_ops = { > .read = mpc_i2c_read, > .write = mpc_i2c_write, > .valid.max_access_size = 1, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_BIG_ENDIAN, > }; > > static const VMStateDescription mpc_i2c_vmstate = { > diff --git a/hw/i2c/versatile_i2c.c b/hw/i2c/versatile_i2c.c > index 1ac2a6f59a..c92d3b115c 100644 > --- a/hw/i2c/versatile_i2c.c > +++ b/hw/i2c/versatile_i2c.c > @@ -77,7 +77,7 @@ static void versatile_i2c_write(void *opaque, hwaddr offset, > static const MemoryRegionOps versatile_i2c_ops = { > .read = versatile_i2c_read, > .write = versatile_i2c_write, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, > }; > > static void versatile_i2c_init(Object *obj)
diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c index 30b9aea247..cc2689d967 100644 --- a/hw/i2c/imx_i2c.c +++ b/hw/i2c/imx_i2c.c @@ -278,7 +278,7 @@ static const MemoryRegionOps imx_i2c_ops = { .write = imx_i2c_write, .valid.min_access_size = 1, .valid.max_access_size = 2, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static const VMStateDescription imx_i2c_vmstate = { diff --git a/hw/i2c/mpc_i2c.c b/hw/i2c/mpc_i2c.c index 0aa1be3ce7..b71b5ff7d5 100644 --- a/hw/i2c/mpc_i2c.c +++ b/hw/i2c/mpc_i2c.c @@ -306,7 +306,7 @@ static const MemoryRegionOps i2c_ops = { .read = mpc_i2c_read, .write = mpc_i2c_write, .valid.max_access_size = 1, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_BIG_ENDIAN, }; static const VMStateDescription mpc_i2c_vmstate = { diff --git a/hw/i2c/versatile_i2c.c b/hw/i2c/versatile_i2c.c index 1ac2a6f59a..c92d3b115c 100644 --- a/hw/i2c/versatile_i2c.c +++ b/hw/i2c/versatile_i2c.c @@ -77,7 +77,7 @@ static void versatile_i2c_write(void *opaque, hwaddr offset, static const MemoryRegionOps versatile_i2c_ops = { .read = versatile_i2c_read, .write = versatile_i2c_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static void versatile_i2c_init(Object *obj)
For each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o. If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively. This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets. These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =) Signed-off-by: Tony Nguyen <tony.nguyen@bt.com> --- hw/i2c/imx_i2c.c | 2 +- hw/i2c/mpc_i2c.c | 2 +- hw/i2c/versatile_i2c.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)