[U-Boot,2/3] imx: initialize fec only when enabled
diff mbox series

Message ID 20190823163510.748006-2-pn@denx.de
State New
Delegated to: Stefano Babic
Headers show
Series
  • [U-Boot,1/3] imx: remove board specific boot order from spl
Related show

Commit Message

Parthiban Nallathambi Aug. 23, 2019, 4:35 p.m. UTC
board early initialize fec ethernet controller pinmux
only when FEC is enabled

Signed-off-by: Parthiban Nallathambi <pn@denx.de>
---
 board/phytec/pcl063/pcl063.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Peng Fan Aug. 26, 2019, 8:26 a.m. UTC | #1
> Subject: [PATCH 2/3] imx: initialize fec only when enabled
> 
> board early initialize fec ethernet controller pinmux only when FEC is enabled
> 
> Signed-off-by: Parthiban Nallathambi <pn@denx.de>
> ---
>  board/phytec/pcl063/pcl063.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/board/phytec/pcl063/pcl063.c b/board/phytec/pcl063/pcl063.c
> index f8cbd1c11e..96dd9e38f3 100644
> --- a/board/phytec/pcl063/pcl063.c
> +++ b/board/phytec/pcl063/pcl063.c
> @@ -178,7 +178,9 @@ int board_phy_config(struct phy_device *phydev)
> int board_early_init_f(void)  {
>  	setup_iomux_uart();
> +#ifdef CONFIG_FEC_MXC
>  	setup_iomux_fec();
> +#endif
> 

Reviewed-by: Peng Fan <peng.fan@nxp.com>

It would be better if dm pinctrl used.

Regards,
Peng.

>  	return 0;
>  }
> --
> 2.21.0

Patch
diff mbox series

diff --git a/board/phytec/pcl063/pcl063.c b/board/phytec/pcl063/pcl063.c
index f8cbd1c11e..96dd9e38f3 100644
--- a/board/phytec/pcl063/pcl063.c
+++ b/board/phytec/pcl063/pcl063.c
@@ -178,7 +178,9 @@  int board_phy_config(struct phy_device *phydev)
 int board_early_init_f(void)
 {
 	setup_iomux_uart();
+#ifdef CONFIG_FEC_MXC
 	setup_iomux_fec();
+#endif
 
 	return 0;
 }