[U-Boot,1/3] imx: remove board specific boot order from spl
diff mbox series

Message ID 20190823163510.748006-1-pn@denx.de
State New
Delegated to: Stefano Babic
Headers show
Series
  • [U-Boot,1/3] imx: remove board specific boot order from spl
Related show

Commit Message

Parthiban Nallathambi Aug. 23, 2019, 4:35 p.m. UTC
boot order was added to handle both SD and eMMC. But commit
14d319b1 introduced to handle both eMMC and SD globally.

Signed-off-by: Parthiban Nallathambi <pn@denx.de>
---
 board/phytec/pcl063/spl.c | 23 -----------------------
 1 file changed, 23 deletions(-)

Comments

Peng Fan Aug. 26, 2019, 8:24 a.m. UTC | #1
> Subject: [PATCH 1/3] imx: remove board specific boot order from spl
> 
> boot order was added to handle both SD and eMMC. But commit
> 14d319b1 introduced to handle both eMMC and SD globally.
> 
> Signed-off-by: Parthiban Nallathambi <pn@denx.de>
> ---
>  board/phytec/pcl063/spl.c | 23 -----------------------
>  1 file changed, 23 deletions(-)
> 
> diff --git a/board/phytec/pcl063/spl.c b/board/phytec/pcl063/spl.c index
> 6d4c827918..18fc251890 100644
> --- a/board/phytec/pcl063/spl.c
> +++ b/board/phytec/pcl063/spl.c
> @@ -182,29 +182,6 @@ int board_mmc_init(bd_t *bis)
> 
>  	return 0;
>  }
> -
> -void board_boot_order(u32 *spl_boot_list) -{
> -	u32 bmode = imx6_src_get_boot_mode();
> -	u8 boot_dev = BOOT_DEVICE_MMC1;
> -
> -	switch ((bmode & IMX6_BMODE_MASK) >> IMX6_BMODE_SHIFT) {
> -	case IMX6_BMODE_SD:
> -	case IMX6_BMODE_ESD:
> -		boot_dev = BOOT_DEVICE_MMC1;
> -		break;
> -	case IMX6_BMODE_MMC:
> -	case IMX6_BMODE_EMMC:
> -		boot_dev = BOOT_DEVICE_MMC2;
> -		break;
> -	default:
> -		/* Default - BOOT_DEVICE_MMC1 */
> -		printf("Wrong board boot order\n");
> -		break;
> -	}
> -
> -	spl_boot_list[0] = boot_dev;
> -}
>  #endif /* CONFIG_FSL_ESDHC_IMX */
> 
>  void board_init_f(ulong dummy)

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> --
> 2.21.0

Patch
diff mbox series

diff --git a/board/phytec/pcl063/spl.c b/board/phytec/pcl063/spl.c
index 6d4c827918..18fc251890 100644
--- a/board/phytec/pcl063/spl.c
+++ b/board/phytec/pcl063/spl.c
@@ -182,29 +182,6 @@  int board_mmc_init(bd_t *bis)
 
 	return 0;
 }
-
-void board_boot_order(u32 *spl_boot_list)
-{
-	u32 bmode = imx6_src_get_boot_mode();
-	u8 boot_dev = BOOT_DEVICE_MMC1;
-
-	switch ((bmode & IMX6_BMODE_MASK) >> IMX6_BMODE_SHIFT) {
-	case IMX6_BMODE_SD:
-	case IMX6_BMODE_ESD:
-		boot_dev = BOOT_DEVICE_MMC1;
-		break;
-	case IMX6_BMODE_MMC:
-	case IMX6_BMODE_EMMC:
-		boot_dev = BOOT_DEVICE_MMC2;
-		break;
-	default:
-		/* Default - BOOT_DEVICE_MMC1 */
-		printf("Wrong board boot order\n");
-		break;
-	}
-
-	spl_boot_list[0] = boot_dev;
-}
 #endif /* CONFIG_FSL_ESDHC_IMX */
 
 void board_init_f(ulong dummy)