[3/4] arch: um: remove misleading #define ARCh_IRQ_ENABLED
diff mbox series

Message ID 20190823104429.11047-3-johannes@sipsolutions.net
State Accepted
Headers show
Series
  • Untitled series #126955
Related show

Commit Message

Johannes Berg Aug. 23, 2019, 10:44 a.m. UTC
From: Johannes Berg <johannes.berg@intel.com>

Due to the typo in the name, this can never be used, but
it's also misleading because our value for enabled/disabled
is always just 0/1, not an actual signal mask.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 arch/um/include/asm/irqflags.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Anton Ivanov Aug. 27, 2019, 5:28 a.m. UTC | #1
On 23/08/2019 11:44, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> Due to the typo in the name, this can never be used, but
> it's also misleading because our value for enabled/disabled
> is always just 0/1, not an actual signal mask.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>   arch/um/include/asm/irqflags.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/um/include/asm/irqflags.h b/arch/um/include/asm/irqflags.h
> index cbc6c0013a64..0642ad9035d1 100644
> --- a/arch/um/include/asm/irqflags.h
> +++ b/arch/um/include/asm/irqflags.h
> @@ -32,7 +32,6 @@ static inline void arch_local_irq_disable(void)
>   }
>   
>   #define ARCH_IRQ_DISABLED	0
> -#define ARCh_IRQ_ENABLED	(SIGIO|SIGVTALRM)
>   
>   #include <asm-generic/irqflags.h>
>   
> 

Acked-by: Anton Ivanov <anton.ivanov@cambridgegreys.co.uk>

Patch
diff mbox series

diff --git a/arch/um/include/asm/irqflags.h b/arch/um/include/asm/irqflags.h
index cbc6c0013a64..0642ad9035d1 100644
--- a/arch/um/include/asm/irqflags.h
+++ b/arch/um/include/asm/irqflags.h
@@ -32,7 +32,6 @@  static inline void arch_local_irq_disable(void)
 }
 
 #define ARCH_IRQ_DISABLED	0
-#define ARCh_IRQ_ENABLED	(SIGIO|SIGVTALRM)
 
 #include <asm-generic/irqflags.h>