| Message ID | 20190823103946.7388-1-dgilbert@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qemu-file: Rework old qemu_fflush comment | expand |
On Fri, Aug 23, 2019 at 11:39:46AM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > Commit 11808bb removed the non-iovec based write support, > the comment hung on. > > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > migration/qemu-file.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel
On Fri, Aug 23, 2019 at 11:39:46AM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > Commit 11808bb removed the non-iovec based write support, > the comment hung on. > > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > migration/qemu-file.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > index e33c46764f..075faf03c3 100644 > --- a/migration/qemu-file.c > +++ b/migration/qemu-file.c > @@ -201,9 +201,8 @@ static void qemu_iovec_release_ram(QEMUFile *f) > /** > * Flushes QEMUFile buffer > * > - * If there is writev_buffer QEMUFileOps it uses it otherwise uses > - * put_buffer ops. This will flush all pending data. If data was > - * only partially flushed, it will set an error state. > + * This will flush all pending data. If data was only partially flushed, it > + * will set an error state. > */ > void qemu_fflush(QEMUFile *f) > { Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote: > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > Commit 11808bb removed the non-iovec based write support, > the comment hung on. > > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com>
* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote: > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > Commit 11808bb removed the non-iovec based write support, > the comment hung on. > > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Queued > --- > migration/qemu-file.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > index e33c46764f..075faf03c3 100644 > --- a/migration/qemu-file.c > +++ b/migration/qemu-file.c > @@ -201,9 +201,8 @@ static void qemu_iovec_release_ram(QEMUFile *f) > /** > * Flushes QEMUFile buffer > * > - * If there is writev_buffer QEMUFileOps it uses it otherwise uses > - * put_buffer ops. This will flush all pending data. If data was > - * only partially flushed, it will set an error state. > + * This will flush all pending data. If data was only partially flushed, it > + * will set an error state. > */ > void qemu_fflush(QEMUFile *f) > { > -- > 2.21.0 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/migration/qemu-file.c b/migration/qemu-file.c index e33c46764f..075faf03c3 100644 --- a/migration/qemu-file.c +++ b/migration/qemu-file.c @@ -201,9 +201,8 @@ static void qemu_iovec_release_ram(QEMUFile *f) /** * Flushes QEMUFile buffer * - * If there is writev_buffer QEMUFileOps it uses it otherwise uses - * put_buffer ops. This will flush all pending data. If data was - * only partially flushed, it will set an error state. + * This will flush all pending data. If data was only partially flushed, it + * will set an error state. */ void qemu_fflush(QEMUFile *f) {