[v2] syscalls/copy_file_range02: use .needs_tmpdir and MAX_LEN
diff mbox series

Message ID 1566547679-2771-1-git-send-email-xuyang2018.jy@cn.fujitsu.com
State Accepted
Delegated to: Petr Vorel
Headers show
Series
  • [v2] syscalls/copy_file_range02: use .needs_tmpdir and MAX_LEN
Related show

Commit Message

Yang Xu Aug. 23, 2019, 8:07 a.m. UTC
Since commit bc514b22, we have removed EXDEV test. all_filesystem
,mount_device and mntpoint make no sense. Remove it and use tmpdir.

As man-page said, when we plan to write at a position past the maximum
allowed offset, it will return EFBIG. We should USE tst_max_lfs_filesize 
as dst instead of (tst_max_lfs_fileszie - MIN_OFF). Also, it doesn't affect 
EOVERFLOW.

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
---
 .../kernel/syscalls/copy_file_range/copy_file_range02.c     | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Petr Vorel Aug. 26, 2019, 9:21 a.m. UTC | #1
Hi all,

> Since commit bc514b22, we have removed EXDEV test. all_filesystem
> ,mount_device and mntpoint make no sense. Remove it and use tmpdir.

> As man-page said, when we plan to write at a position past the maximum
> allowed offset, it will return EFBIG. We should USE tst_max_lfs_filesize 
> as dst instead of (tst_max_lfs_fileszie - MIN_OFF). Also, it doesn't affect 
> EOVERFLOW.

> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
Thanks for the fix. I tempted to split these 2 changes into 2 commits,
but in the end kept it in single commit.

Merged (with adjusted commit message and
Reported-by for Murphy Zhou and Signed-off-by for Li as he did a review for
previous version).

Kind regards,
Petr

Patch
diff mbox series

diff --git a/testcases/kernel/syscalls/copy_file_range/copy_file_range02.c b/testcases/kernel/syscalls/copy_file_range/copy_file_range02.c
index a08df9bdb..d6e843ee4 100644
--- a/testcases/kernel/syscalls/copy_file_range/copy_file_range02.c
+++ b/testcases/kernel/syscalls/copy_file_range/copy_file_range02.c
@@ -115,7 +115,7 @@  static void verify_copy_file_range(unsigned int n)
 	}
 
 	if (tc->copy_to_fd == &fd_copy)
-		dst = tst_max_lfs_filesize() - MIN_OFF;
+		dst = tst_max_lfs_filesize();
 
 	TEST(sys_copy_file_range(fd_src, 0, *tc->copy_to_fd,
 				&dst, tc->len, tc->flags));
@@ -224,8 +224,6 @@  static struct tst_test test = {
 	.setup = setup,
 	.cleanup = cleanup,
 	.needs_root = 1,
-	.mount_device = 1,
-	.mntpoint = MNTPOINT,
-	.all_filesystems = 1,
+	.needs_tmpdir = 1,
 	.test_variants = TEST_VARIANTS,
 };