From patchwork Thu Aug 22 13:19:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauricio Faria de Oliveira X-Patchwork-Id: 1151598 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46DlWt1Q0Jz9sNy; Thu, 22 Aug 2019 23:20:25 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1i0n0i-0005C3-JI; Thu, 22 Aug 2019 13:20:16 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1i0n0g-0005Bu-C5 for kernel-team@lists.ubuntu.com; Thu, 22 Aug 2019 13:20:14 +0000 Received: from mail-qk1-f197.google.com ([209.85.222.197]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1i0n0g-000786-04 for kernel-team@lists.ubuntu.com; Thu, 22 Aug 2019 13:20:14 +0000 Received: by mail-qk1-f197.google.com with SMTP id c79so5746390qkg.13 for ; Thu, 22 Aug 2019 06:20:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=XQwff27jq1cpk1YamZulzynLPG/n4bpHY8DVXOU2HZI=; b=AZ0ml1gxwAYqsJXm87bZQxu1ujLoCT5vsT1YArZgjkW9FOQmb7uOvzS2KNF/Dvs0E8 dr8dIpQ4CEDbDnHv/1Wdvr4V2AJaXsdJN8zYof4oJUVszezAqvgSaOgTqQGZC4ytGRMd ULzMSNFIcmjv5zsQqd8xiSZExhwoS3HnD/BZHVbrNSdQmtFALCJGm1gZxmGVPAlttXSP On3yKS7FPumdZlpU5vYucT56V5Kn6Qr34MgPFmYFnLeFaxjgWyoYGhS/hvs7wROLmVal GbxjrbJvoRHpDX28q3IyMoE8oX7VF71qjIa23mHt/E4edT6TphuJ2NfWNLGms6QEbtvr gOww== X-Gm-Message-State: APjAAAXIXaHJL5XYOTomjwMaoeCDms0iuki8srH7miHVg6u9mOeev9YS K9K5dgirrKj8lQWmKLqtkkZQGWkJnLYOxGNURGF+RczqUMEre4f+X9tVvr9PQxL94cq9382OzKu uh+JJuYG1QS3S5yUxhdRFqM0MqkDbxtV1x0MuMrkggA== X-Received: by 2002:ac8:794f:: with SMTP id r15mr2406566qtt.130.1566480013019; Thu, 22 Aug 2019 06:20:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqxa/YOYnea6zv+z50yNtEGWK24JVXoWz3CcFMryuV2HbuxEsiHyCr2tkt+Q93TbRAZriLgrnA== X-Received: by 2002:ac8:794f:: with SMTP id r15mr2406553qtt.130.1566480012840; Thu, 22 Aug 2019 06:20:12 -0700 (PDT) Received: from localhost.localdomain ([2804:14c:4e7:1017:a993:97d5:bc07:a234]) by smtp.gmail.com with ESMTPSA id z2sm12339325qtq.7.2019.08.22.06.20.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2019 06:20:12 -0700 (PDT) From: Mauricio Faria de Oliveira To: kernel-team@lists.ubuntu.com Subject: [X/B][PATCH] bnx2x: Disable multi-cos feature. Date: Thu, 22 Aug 2019 10:19:28 -0300 Message-Id: <20190822131928.31105-1-mfo@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Sudarsana Reddy Kalluru BugLink: https://bugs.launchpad.net/bugs/1840789 Commit 3968d38917eb ("bnx2x: Fix Multi-Cos.") which enabled multi-cos feature after prolonged time in driver added some regression causing numerous issues (sudden reboots, tx timeout etc.) reported by customers. We plan to backout this commit and submit proper fix once we have root cause of issues reported with this feature enabled. Fixes: 3968d38917eb ("bnx2x: Fix Multi-Cos.") Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Manish Chopra Signed-off-by: David S. Miller (backported from commit d1f0b5dce8fda09a7f5f04c1878f181d548e42f5) [mfo: backport: essentially revert the mentioned commit; upstream more recently removed the fallback() function and moved to netdev_pick_tx(), and has more arguments. the parentheses are left in as done in this commit.] Signed-off-by: Mauricio Faria de Oliveira Acked-by: Stefan Bader --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index 5d1796ab3403..641caef6ce31 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c @@ -1954,7 +1954,7 @@ u16 bnx2x_select_queue(struct net_device *dev, struct sk_buff *skb, } /* select a non-FCoE queue */ - return fallback(dev, skb) % (BNX2X_NUM_ETH_QUEUES(bp) * bp->max_cos); + return fallback(dev, skb) % (BNX2X_NUM_ETH_QUEUES(bp)); } void bnx2x_set_num_queues(struct bnx2x *bp)