| Message ID | 20190822063517.71231-1-yuehaibing@huawei.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] cirrus: cs89x0: remove set but not used variable 'lp' | expand |
From: YueHaibing <yuehaibing@huawei.com> Date: Thu, 22 Aug 2019 06:35:17 +0000 > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/cirrus/cs89x0.c: In function 'cs89x0_platform_probe': > drivers/net/ethernet/cirrus/cs89x0.c:1847:20: warning: > variable 'lp' set but not used [-Wunused-but-set-variable] > > It is not used since commit 6751edeb8700 ("cirrus: cs89x0: Use > managed interfaces") Please use a proper Fixes: tag.
diff --git a/drivers/net/ethernet/cirrus/cs89x0.c b/drivers/net/ethernet/cirrus/cs89x0.c index 2d30972df06b..c9aebcde403a 100644 --- a/drivers/net/ethernet/cirrus/cs89x0.c +++ b/drivers/net/ethernet/cirrus/cs89x0.c @@ -1844,15 +1844,12 @@ cleanup_module(void) static int __init cs89x0_platform_probe(struct platform_device *pdev) { struct net_device *dev = alloc_etherdev(sizeof(struct net_local)); - struct net_local *lp; void __iomem *virt_addr; int err; if (!dev) return -ENOMEM; - lp = netdev_priv(dev); - dev->irq = platform_get_irq(pdev, 0); if (dev->irq <= 0) { dev_warn(&dev->dev, "interrupt resource missing\n");
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/cirrus/cs89x0.c: In function 'cs89x0_platform_probe': drivers/net/ethernet/cirrus/cs89x0.c:1847:20: warning: variable 'lp' set but not used [-Wunused-but-set-variable] It is not used since commit 6751edeb8700 ("cirrus: cs89x0: Use managed interfaces") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/ethernet/cirrus/cs89x0.c | 3 --- 1 file changed, 3 deletions(-)