[1/1] package/capnproto: increase gcc version dependency
diff mbox series

Message ID 20190821132153.GC26497@coltrane
State Rejected
Headers show
Series
  • [1/1] package/capnproto: increase gcc version dependency
Related show

Commit Message

Koen Martens Aug. 21, 2019, 1:21 p.m. UTC
The new version of capnproto requires c++14, therefore
the dependency has been increase from at least gcc 4.8
to at least gcc 5.x.

This patch should be applied to a branch that already
has the patch that increases the capnproto version to
0.7.0. At the time of writing this, that means the next
branch.

Signed-off-by: Koen Martens <gmc@sonologic.nl>
---
 package/capnproto/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Koen Martens Sept. 2, 2019, 6:06 p.m. UTC | #1
Hi List,

On Wed, Aug 21, 2019 at 03:21:54PM +0200, Koen Martens wrote:
> The new version of capnproto requires c++14, therefore
> the dependency has been increase from at least gcc 4.8
> to at least gcc 5.x.
> 
> This patch should be applied to a branch that already
> has the patch that increases the capnproto version to
> 0.7.0. At the time of writing this, that means the next
> branch.

This patch hasn't been merged yet, but i'm unsubscribing from the
list again because the volume is overwhelming my inbox. If anyone
wants to discuss this patch, please mail me off-list.

Cheers,

Koen
Thomas Petazzoni Sept. 10, 2019, 10:04 a.m. UTC | #2
On Wed, 21 Aug 2019 15:21:54 +0200
Koen Martens <gmc@sonologic.nl> wrote:

> The new version of capnproto requires c++14, therefore
> the dependency has been increase from at least gcc 4.8
> to at least gcc 5.x.
> 
> This patch should be applied to a branch that already
> has the patch that increases the capnproto version to
> 0.7.0. At the time of writing this, that means the next
> branch.
> 
> Signed-off-by: Koen Martens <gmc@sonologic.nl>

Thanks for this contribution. Unfortunately, your patch wasn't correct:
it was only updating the Config.in, but not the dependency of the
package itself, so it was in fact doing nothing. Also, c-capnproto had
to be fixed as well, as it selects capnproto. In the mean time, Joel
Carlson provided correct patches, which I just merged.

Thanks,

Thomas
Thomas Petazzoni Sept. 10, 2019, 10:41 a.m. UTC | #3
On Mon, 2 Sep 2019 20:06:58 +0200
Koen Martens <gmc@sonologic.nl> wrote:

> This patch hasn't been merged yet, but i'm unsubscribing from the
> list again because the volume is overwhelming my inbox. If anyone
> wants to discuss this patch, please mail me off-list.

That's quite worrying that people can't stay subscribed due to the
traffic, so I'm interested in having a discussion here to understand
what can be done about this.

Have you set up a filter to have the mailing list traffic out of your
Inbox, and go into a dedicated folder ? The good way of doing that is
to filter on the List-Id, so that the e-mails of the mailing list go
into a separate folder, but you still receive in your Inbox the e-mails
that have both you in To/Cc and the mailing list in To/Cc.

Another option is to remain subscribe, but disable mail delivery, so
that you can still post patches, but won't receive any e-mail from the
list.

Thomas

Patch
diff mbox series

diff --git a/package/capnproto/Config.in b/package/capnproto/Config.in
index a979a334ff..a81b7c9d96 100644
--- a/package/capnproto/Config.in
+++ b/package/capnproto/Config.in
@@ -15,10 +15,10 @@  config BR2_PACKAGE_CAPNPROTO
 
 	  https://capnproto.org/index.html
 
-comment "capnproto needs host and target gcc >= 4.8 w/ C++, threads, atomic"
+comment "capnproto needs host and target gcc >= 5 w/ C++, threads, atomic"
 	depends on BR2_USE_MMU
-	depends on !BR2_HOST_GCC_AT_LEAST_4_8 || \
-		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
+	depends on !BR2_HOST_GCC_AT_LEAST_5 || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_5 || \
 		!BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_HAS_THREADS || \
 		!BR2_TOOLCHAIN_HAS_ATOMIC