| Message ID | 20190821095442.24495-2-sibis@codeaurora.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Add PDC Global and AOSS reset support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Wed, 2019-08-21 at 15:24 +0530, Sibi Sankar wrote: > Add SC7180 AOSS reset to the list of possible bindings. > > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> > --- > Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt > index 510c748656ec5..8f0bbdc6afd91 100644 > --- a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt > +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt > @@ -8,7 +8,8 @@ Required properties: > - compatible: > Usage: required > Value type: <string> > - Definition: must be: > + Definition: must be one of: > + "qcom,sc7180-aoss-cc" > "qcom,sdm845-aoss-cc" > > - reg: Does sc7180 have exactly the same resets (mss, camss, venus, gpu, dispss, wcss, and lpass) as sdm845? If so, it could be considered compatible, and the driver changes wouldn't be needed at all: - Definition: must be: + Definition: must be one of: + "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" "qcom,sdm845-aoss-cc" Is there a reason not to do this? regards Philipp
Hey Philipp, Thanks for the review! On 2019-08-21 16:02, Philipp Zabel wrote: > On Wed, 2019-08-21 at 15:24 +0530, Sibi Sankar wrote: >> Add SC7180 AOSS reset to the list of possible bindings. >> >> Signed-off-by: Sibi Sankar <sibis@codeaurora.org> >> --- >> Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> index 510c748656ec5..8f0bbdc6afd91 100644 >> --- a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> @@ -8,7 +8,8 @@ Required properties: >> - compatible: >> Usage: required >> Value type: <string> >> - Definition: must be: >> + Definition: must be one of: >> + "qcom,sc7180-aoss-cc" >> "qcom,sdm845-aoss-cc" >> >> - reg: > > Does sc7180 have exactly the same resets (mss, camss, venus, gpu, > dispss, wcss, and lpass) as sdm845? If so, it could be considered > compatible, and the driver changes wouldn't be needed at all: Yes they are identical both AOSS and PDC resets. > > - Definition: must be: > + Definition: must be one of: > + "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" > > "qcom,sdm845-aoss-cc" > > Is there a reason not to do this? I am fine with ^^, will change them in v2. > > regards > Philipp
diff --git a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt index 510c748656ec5..8f0bbdc6afd91 100644 --- a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt @@ -8,7 +8,8 @@ Required properties: - compatible: Usage: required Value type: <string> - Definition: must be: + Definition: must be one of: + "qcom,sc7180-aoss-cc" "qcom,sdm845-aoss-cc" - reg:
Add SC7180 AOSS reset to the list of possible bindings. Signed-off-by: Sibi Sankar <sibis@codeaurora.org> --- Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)