[SRU,D/E/Unstable,Pull] Fix non-working Realtek WiFi 8822BE
mbox series

Message ID 20190821070619.19902-1-kai.heng.feng@canonical.com
State New
Headers show
Series
  • [SRU,D/E/Unstable,Pull] Fix non-working Realtek WiFi 8822BE
Related show

Pull-request

https://git.launchpad.net/~kaihengfeng/linux lp1838133-unstable

Message

Kai-Heng Feng Aug. 21, 2019, 7:06 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1838133

[Impact]
Realtek Wifi stops working after the driver changed from rtlwifi to
rtw88.

[Fix]
Sync rtw88 to upstream version, and use MSI on the device.

[Test]
User confirmed the backport fixes the issue.

[Regression Potential]
Low. Currently only 8822be uses rtw88.

[Disco]
The following changes since commit e73cc011b6b50eb170b759000000180ffee03167:

  UBUNTU: upstream stable to v4.19.55, v5.1.14 (2019-08-13 15:50:23 -0400)

are available in the Git repository at:

  https://git.launchpad.net/~kaihengfeng/linux lp1838133-disco

for you to fetch changes up to 9d2baf760bff7fe5c368f6c7ffc7908d80aebcca:

  UBUNTU: SAUCE: rtw88: pci: enable MSI interrupt (2019-08-21 03:23:32 +0800)

[Eoan]
The following changes since commit b9407f8a57383eb8978895858af48b6d484dd9b7:

  UBUNTU: Ubuntu-5.2.0-13.14 (2019-08-15 08:35:06 -0500)

are available in the Git repository at:

  https://git.launchpad.net/~kaihengfeng/linux lp1838133-eoan

for you to fetch changes up to 5007de59c1293a931fff16dca760b4924f37a539:

  UBUNTU: SAUCE: rtw88: pci: enable MSI interrupt (2019-08-21 14:52:14 +0800)

[Unstable]
The following changes since commit e28b204391b4788daa14c628f87a7428e584eaf4:

  UBUNTU: Ubuntu-5.3.0-7.8 (2019-08-19 15:31:24 +0200)

are available in the Git repository at:

  https://git.launchpad.net/~kaihengfeng/linux lp1838133-unstable

for you to fetch changes up to 855b178bb7170eeb777d4ed93167e2cf814117c2:

  UBUNTU: SAUCE: rtw88: pci: enable MSI interrupt (2019-08-21 01:53:21 +0800)

Comments

Seth Forshee Aug. 23, 2019, 3:17 a.m. UTC | #1
On Wed, Aug 21, 2019 at 03:06:19PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1838133
> 
> [Impact]
> Realtek Wifi stops working after the driver changed from rtlwifi to
> rtw88.
> 
> [Fix]
> Sync rtw88 to upstream version, and use MSI on the device.
> 
> [Test]
> User confirmed the backport fixes the issue.
> 
> [Regression Potential]
> Low. Currently only 8822be uses rtw88.
> 
> [Disco]
> The following changes since commit e73cc011b6b50eb170b759000000180ffee03167:
> 
>   UBUNTU: upstream stable to v4.19.55, v5.1.14 (2019-08-13 15:50:23 -0400)
> 
> are available in the Git repository at:
> 
>   https://git.launchpad.net/~kaihengfeng/linux lp1838133-disco
> 
> for you to fetch changes up to 9d2baf760bff7fe5c368f6c7ffc7908d80aebcca:
> 
>   UBUNTU: SAUCE: rtw88: pci: enable MSI interrupt (2019-08-21 03:23:32 +0800)
> 
> [Eoan]
> The following changes since commit b9407f8a57383eb8978895858af48b6d484dd9b7:
> 
>   UBUNTU: Ubuntu-5.2.0-13.14 (2019-08-15 08:35:06 -0500)
> 
> are available in the Git repository at:
> 
>   https://git.launchpad.net/~kaihengfeng/linux lp1838133-eoan
> 
> for you to fetch changes up to 5007de59c1293a931fff16dca760b4924f37a539:
> 
>   UBUNTU: SAUCE: rtw88: pci: enable MSI interrupt (2019-08-21 14:52:14 +0800)
> 
> [Unstable]
> The following changes since commit e28b204391b4788daa14c628f87a7428e584eaf4:
> 
>   UBUNTU: Ubuntu-5.3.0-7.8 (2019-08-19 15:31:24 +0200)
> 
> are available in the Git repository at:
> 
>   https://git.launchpad.net/~kaihengfeng/linux lp1838133-unstable
> 
> for you to fetch changes up to 855b178bb7170eeb777d4ed93167e2cf814117c2:
> 
>   UBUNTU: SAUCE: rtw88: pci: enable MSI interrupt (2019-08-21 01:53:21 +0800)

It's a lot of changes, but the scope is limited, the patches are mostly
cherry picks from upstream or linux-next, and positive testing on the
bug.

Acked-by: Seth Forshee <seth.forshee@canonical.com>

Applied to eoan/master-next and unstable/master, thanks!
Kleber Souza Sept. 2, 2019, 3:45 p.m. UTC | #2
On 8/21/19 9:06 AM, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1838133
> 
> [Impact]
> Realtek Wifi stops working after the driver changed from rtlwifi to
> rtw88.
> 
> [Fix]
> Sync rtw88 to upstream version, and use MSI on the device.
> 
> [Test]
> User confirmed the backport fixes the issue.
> 
> [Regression Potential]
> Low. Currently only 8822be uses rtw88.
> 
> [Disco]
> The following changes since commit e73cc011b6b50eb170b759000000180ffee03167:
> 
>   UBUNTU: upstream stable to v4.19.55, v5.1.14 (2019-08-13 15:50:23 -0400)
> 
> are available in the Git repository at:
> 
>   https://git.launchpad.net/~kaihengfeng/linux lp1838133-disco
> 
> for you to fetch changes up to 9d2baf760bff7fe5c368f6c7ffc7908d80aebcca:
> 
>   UBUNTU: SAUCE: rtw88: pci: enable MSI interrupt (2019-08-21 03:23:32 +0800)

The following patches don't seem to be related to the Realtek driver:

- lib/vsprintf.c: move sizeof(struct printf_spec) next to its definition
- linux/fs.h: move member alignment check next to definition of struct filename

But they look harmless, so I'm OK with applying them to Disco.

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> 
> [Eoan]
> The following changes since commit b9407f8a57383eb8978895858af48b6d484dd9b7:
> 
>   UBUNTU: Ubuntu-5.2.0-13.14 (2019-08-15 08:35:06 -0500)
> 
> are available in the Git repository at:
> 
>   https://git.launchpad.net/~kaihengfeng/linux lp1838133-eoan
> 
> for you to fetch changes up to 5007de59c1293a931fff16dca760b4924f37a539:
> 
>   UBUNTU: SAUCE: rtw88: pci: enable MSI interrupt (2019-08-21 14:52:14 +0800)
> 
> [Unstable]
> The following changes since commit e28b204391b4788daa14c628f87a7428e584eaf4:
> 
>   UBUNTU: Ubuntu-5.3.0-7.8 (2019-08-19 15:31:24 +0200)
> 
> are available in the Git repository at:
> 
>   https://git.launchpad.net/~kaihengfeng/linux lp1838133-unstable
> 
> for you to fetch changes up to 855b178bb7170eeb777d4ed93167e2cf814117c2:
> 
>   UBUNTU: SAUCE: rtw88: pci: enable MSI interrupt (2019-08-21 01:53:21 +0800)
>
Kleber Souza Sept. 3, 2019, 4:20 p.m. UTC | #3
On 8/21/19 9:06 AM, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1838133
> 
> [Impact]
> Realtek Wifi stops working after the driver changed from rtlwifi to
> rtw88.
> 
> [Fix]
> Sync rtw88 to upstream version, and use MSI on the device.
> 
> [Test]
> User confirmed the backport fixes the issue.
> 
> [Regression Potential]
> Low. Currently only 8822be uses rtw88.
> 
> [Disco]
> The following changes since commit e73cc011b6b50eb170b759000000180ffee03167:
> 
>   UBUNTU: upstream stable to v4.19.55, v5.1.14 (2019-08-13 15:50:23 -0400)
> 
> are available in the Git repository at:
> 
>   https://git.launchpad.net/~kaihengfeng/linux lp1838133-disco
> 
> for you to fetch changes up to 9d2baf760bff7fe5c368f6c7ffc7908d80aebcca:
> 
>   UBUNTU: SAUCE: rtw88: pci: enable MSI interrupt (2019-08-21 03:23:32 +0800)

Applied to disco/master-next branch.

Thanks,
Kleber


> 
> [Eoan]
> The following changes since commit b9407f8a57383eb8978895858af48b6d484dd9b7:
> 
>   UBUNTU: Ubuntu-5.2.0-13.14 (2019-08-15 08:35:06 -0500)
> 
> are available in the Git repository at:
> 
>   https://git.launchpad.net/~kaihengfeng/linux lp1838133-eoan
> 
> for you to fetch changes up to 5007de59c1293a931fff16dca760b4924f37a539:
> 
>   UBUNTU: SAUCE: rtw88: pci: enable MSI interrupt (2019-08-21 14:52:14 +0800)
> 
> [Unstable]
> The following changes since commit e28b204391b4788daa14c628f87a7428e584eaf4:
> 
>   UBUNTU: Ubuntu-5.3.0-7.8 (2019-08-19 15:31:24 +0200)
> 
> are available in the Git repository at:
> 
>   https://git.launchpad.net/~kaihengfeng/linux lp1838133-unstable
> 
> for you to fetch changes up to 855b178bb7170eeb777d4ed93167e2cf814117c2:
> 
>   UBUNTU: SAUCE: rtw88: pci: enable MSI interrupt (2019-08-21 01:53:21 +0800)
>