Patchwork [1/3] trace: Fix print format for "mipsnet_write"

login
register
mail settings
Submitter Lluís Vilanova
Date Sept. 16, 2011, 4:59 p.m.
Message ID <20110916165933.16620.4383.stgit@ginnungagap.bsc.es>
Download mbox | patch
Permalink /patch/115002/
State New
Headers show

Comments

Lluís Vilanova - Sept. 16, 2011, 4:59 p.m.
Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---
 trace-events |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Stefan Hajnoczi - Sept. 20, 2011, 7:32 a.m.
On Fri, Sep 16, 2011 at 06:59:33PM +0200, Lluís Vilanova wrote:
> diff --git a/trace-events b/trace-events
> index c09399f..9d1fbbb 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -454,7 +454,7 @@ milkymist_vgafb_memory_write(uint32_t addr, uint32_t value) "addr %08x value %08
>  mipsnet_send(uint32_t size) "sending len=%u"
>  mipsnet_receive(uint32_t size) "receiving len=%u"
>  mipsnet_read(uint64_t addr, uint32_t val) "read addr=0x%" PRIx64 " val=0x%x"
> -mipsnet_write(uint64_t addr, uint64_t val) "write addr=0x%" PRIx64 " val=0x%" PRIx64
> +mipsnet_write(uint64_t addr, uint64_t val) "write addr=0x%" PRIx64 " val=0x%" PRIx64 ""

This limitation of the tracetool parser has been removed in commit
913540a376f01569227b9a6480a2e96ae9d1d406.

Stefan

Patch

diff --git a/trace-events b/trace-events
index c09399f..9d1fbbb 100644
--- a/trace-events
+++ b/trace-events
@@ -454,7 +454,7 @@  milkymist_vgafb_memory_write(uint32_t addr, uint32_t value) "addr %08x value %08
 mipsnet_send(uint32_t size) "sending len=%u"
 mipsnet_receive(uint32_t size) "receiving len=%u"
 mipsnet_read(uint64_t addr, uint32_t val) "read addr=0x%" PRIx64 " val=0x%x"
-mipsnet_write(uint64_t addr, uint64_t val) "write addr=0x%" PRIx64 " val=0x%" PRIx64
+mipsnet_write(uint64_t addr, uint64_t val) "write addr=0x%" PRIx64 " val=0x%" PRIx64 ""
 mipsnet_irq(uint32_t isr, uint32_t intctl) "set irq to %d (%02x)"
 
 # xen-all.c