[Ada] Improve efficiency of aggregates with <>
diff mbox series

Message ID 20190820095128.GA75590@adacore.com
State New
Headers show
Series
  • [Ada] Improve efficiency of aggregates with <>
Related show

Commit Message

Pierre-Marie de Rodat Aug. 20, 2019, 9:51 a.m. UTC
The generated code has been improved so that aggregates with <> are more
efficient.  No change in behavior; no test.

Tested on x86_64-pc-linux-gnu, committed on trunk

2019-08-20  Bob Duff  <duff@adacore.com>

gcc/ada/

	* exp_aggr.adb (Expand_Array_Aggregate): Use build-in-place in
	the nonlimited case in STEP 4. This improves the efficiency of
	things like (1 .. 1000 => <>).  We still generate some code for
	that, unfortunately, but it is much improved.
	(Aggr_Assignment_OK_For_Backend): Return false if <> components
	are present.

Patch
diff mbox series

--- gcc/ada/exp_aggr.adb
+++ gcc/ada/exp_aggr.adb
@@ -5233,6 +5233,12 @@  package body Exp_Aggr is
          Value     : Uint;
 
       begin
+         --  Back end doesn't know about <>
+
+         if Has_Default_Init_Comps (N) then
+            return False;
+         end if;
+
          --  Recurse as far as possible to find the innermost component type
 
          Ctyp := Etype (N);
@@ -6292,9 +6298,7 @@  package body Exp_Aggr is
       --  previously excluded controlled components but this is an old
       --  oversight: the rules in 7.6 (17) are clear.
 
-      if (not Has_Default_Init_Comps (N)
-           or else Is_Limited_Type (Etype (N)))
-        and then Comes_From_Source (Parent_Node)
+      if Comes_From_Source (Parent_Node)
         and then Parent_Kind = N_Object_Declaration
         and then Present (Expression (Parent_Node))
         and then not