From patchwork Tue Aug 20 09:51:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 1149995 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-507353-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="DXO/2dws"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46CR2m3Tg9z9s4Y for ; Tue, 20 Aug 2019 19:54:08 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=SoTWtz/UrvqtdCakV+hTV5kuK7PvtWIeGgmHfp1SQuXcWSVFR1 36uRkqUC1gQ4wkOhBOy4u54eBkvfdoLjL55tf/Gj0imXsvA5PsoKf0MKU0M3q0uG hCaaIZWdQTXyYOrzK4K7k8az1rbHrL+GAYVLKSAsPy4ty8ooGWlu91XCY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=WgqAGNxM0R8WWHE3KMbsMRvztpg=; b=DXO/2dwsGD1syBKwlDW0 T74/fIS/tmtfSAJQ+8Y2jwOTguvZL2QcTewsmL062cbd/5zfn5WUcQru05eSV3V5 wL1abB1v8eIMa1buRFaPm4BTiozlT+VK/8LoSyveyJjuRhnOPVrvamGUBIIT9oGw CC7AO7RBp928WUJF4jSyQko= Received: (qmail 122457 invoked by alias); 20 Aug 2019 09:51:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 122102 invoked by uid 89); 20 Aug 2019 09:51:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, SPF_NEUTRAL autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Aug 2019 09:51:29 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i00nX-0005L0-56 for gcc-patches@gcc.gnu.org; Tue, 20 Aug 2019 05:51:28 -0400 Received: from rock.gnat.com ([2620:20:4000:0:a9e:1ff:fe9b:1d1]:55477) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i00nX-0005J1-0r for gcc-patches@gcc.gnu.org; Tue, 20 Aug 2019 05:51:27 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 88916560C0; Tue, 20 Aug 2019 05:51:22 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id UEChB0pHZoHJ; Tue, 20 Aug 2019 05:51:22 -0400 (EDT) Received: from tron.gnat.com (tron.gnat.com [205.232.38.10]) by rock.gnat.com (Postfix) with ESMTP id 77AC4560BF; Tue, 20 Aug 2019 05:51:22 -0400 (EDT) Received: by tron.gnat.com (Postfix, from userid 4862) id 76D0A63E; Tue, 20 Aug 2019 05:51:22 -0400 (EDT) Date: Tue, 20 Aug 2019 05:51:22 -0400 From: Pierre-Marie de Rodat To: gcc-patches@gcc.gnu.org Cc: Bob Duff Subject: [Ada] Efficiency improvement in bounded ordered containers Message-ID: <20190820095121.GA75446@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 2620:20:4000:0:a9e:1ff:fe9b:1d1 X-IsSubscribed: yes The Delete operations in the bounded ordered containers have been substantially sped up. No change in semantics, so no test. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-08-20 Bob Duff gcc/ada/ * libgnat/a-cborma.adb, libgnat/a-cborse.adb (Clear): Repeatedly call Delete. This avoids clearing the free list, which substantially speeds up future Delete operations. --- gcc/ada/libgnat/a-cborma.adb +++ gcc/ada/libgnat/a-cborma.adb @@ -374,7 +374,9 @@ package body Ada.Containers.Bounded_Ordered_Maps is procedure Clear (Container : in out Map) is begin - Tree_Operations.Clear_Tree (Container); + while not Container.Is_Empty loop + Container.Delete_Last; + end loop; end Clear; ----------- --- gcc/ada/libgnat/a-cborse.adb +++ gcc/ada/libgnat/a-cborse.adb @@ -374,7 +374,9 @@ package body Ada.Containers.Bounded_Ordered_Sets is procedure Clear (Container : in out Set) is begin - Tree_Operations.Clear_Tree (Container); + while not Container.Is_Empty loop + Container.Delete_Last; + end loop; end Clear; -----------