From patchwork Fri Sep 16 16:13:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aneesh V X-Patchwork-Id: 114976 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 90B5FB6F80 for ; Sat, 17 Sep 2011 02:16:25 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 27007285D6; Fri, 16 Sep 2011 18:16:23 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q6IGrzq4g7Kv; Fri, 16 Sep 2011 18:16:22 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 522A9285FC; Fri, 16 Sep 2011 18:16:19 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id B7E26285FC for ; Fri, 16 Sep 2011 18:16:15 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2yFqHwHfLems for ; Fri, 16 Sep 2011 18:16:14 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from na3sys009aog107.obsmtp.com (na3sys009aog107.obsmtp.com [74.125.149.197]) by theia.denx.de (Postfix) with ESMTPS id 751D8285D6 for ; Fri, 16 Sep 2011 18:16:11 +0200 (CEST) Received: from mail-yw0-f46.google.com ([209.85.213.46]) (using TLSv1) by na3sys009aob107.postini.com ([74.125.148.12]) with SMTP ID DSNKTnN2SbIGX6STyEnoXDIllUJePUSUKIJ3@postini.com; Fri, 16 Sep 2011 09:16:13 PDT Received: by mail-yw0-f46.google.com with SMTP id 5so3729727ywb.5 for ; Fri, 16 Sep 2011 09:16:09 -0700 (PDT) Received: by 10.236.175.233 with SMTP id z69mr12570664yhl.122.1316189769547; Fri, 16 Sep 2011 09:16:09 -0700 (PDT) Received: from [172.24.137.55] (dragon.ti.com. [192.94.94.33]) by mx.google.com with ESMTPS id v28sm8095521yhi.11.2011.09.16.09.16.05 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 16 Sep 2011 09:16:08 -0700 (PDT) Message-ID: <4E7375C0.2020403@ti.com> Date: Fri, 16 Sep 2011 21:43:52 +0530 From: Aneesh V User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100915 Thunderbird/3.0.8 MIME-Version: 1.0 To: Simon Schwarz References: <1316187178-13700-1-git-send-email-simonschwarzcor@gmail.com> In-Reply-To: <1316187178-13700-1-git-send-email-simonschwarzcor@gmail.com> Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] armv7: only call save_boot_params for OMAP X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Hi Simon, On Friday 16 September 2011 09:02 PM, Simon Schwarz wrote: > save_boot_params in start.S got called for all armv7 based cpus. Since the > function relys on the OMAP specific bootloader this broke some boards > (or to be specific added more errors to already broken ones). This patch > wraps the call in #ifdef CONFIG_OMAP. There is a weakly linked default function implemented in armv7/cpu.c. So, there should not be any build break for u-boot builds. However armv7/cpu.c is not included in an SPL build, so may cause trouble for SPL build of non-OMAP boards. The solution for this problem is the following: Let me know if I am missing something. best regards, Aneesh > > Signed-off-by: Simon Schwarz > --- > arch/arm/cpu/armv7/start.S | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S > index db8e9d2..7cb380c 100644 > --- a/arch/arm/cpu/armv7/start.S > +++ b/arch/arm/cpu/armv7/start.S > @@ -134,7 +134,9 @@ IRQ_STACK_START_IN: > */ > > reset: > +#ifdef CONFIG_OMAP > bl save_boot_params > +#endif > /* > * set the cpu to SVC32 mode > */ --- a/arch/arm/cpu/armv7/Makefile +++ b/arch/arm/cpu/armv7/Makefile @@ -29,9 +29,9 @@ START := start.o ifndef CONFIG_SPL_BUILD COBJS += cache_v7.o -COBJS += cpu.o endif +COBJS += cpu.o COBJS += syslib.o SRCS := $(START:.o=.S) $(COBJS:.o=.c)