ACPI/PCI: Remove surplus parentheses from a return statement
diff mbox series

Message ID 20190819135324.29504-1-kw@linux.com
State Not Applicable
Headers show
Series
  • ACPI/PCI: Remove surplus parentheses from a return statement
Related show

Commit Message

Krzysztof Wilczynski Aug. 19, 2019, 1:53 p.m. UTC
Remove unnecessary parentheses enclosing the value in a return
statement in the drivers/acpi/pci_link.c.

Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
---
 drivers/acpi/pci_link.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andrew Murray Aug. 19, 2019, 5:25 p.m. UTC | #1
On Mon, Aug 19, 2019 at 03:53:24PM +0200, Krzysztof Wilczynski wrote:
> Remove unnecessary parentheses enclosing the value in a return
> statement in the drivers/acpi/pci_link.c.
> 
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
> ---
>  drivers/acpi/pci_link.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> index db11f7771ef1..00a6da2121be 100644
> --- a/drivers/acpi/pci_link.c
> +++ b/drivers/acpi/pci_link.c
> @@ -661,7 +661,7 @@ int acpi_pci_link_allocate_irq(acpi_handle handle, int index, int *triggering,
>  	ACPI_DEBUG_PRINT((ACPI_DB_INFO,
>  			  "Link %s is referenced\n",
>  			  acpi_device_bid(link->device)));
> -	return (link->irq.active);
> +	return link->irq.active;
>  }
>  
>  /*
> @@ -712,7 +712,7 @@ int acpi_pci_link_free_irq(acpi_handle handle)
>  		acpi_evaluate_object(link->device->handle, "_DIS", NULL, NULL);
>  
>  	mutex_unlock(&acpi_link_lock);
> -	return (link->irq.active);
> +	return link->irq.active;

It looks like these parentheses were left over after a patch that removed some
macros:

 ad550d98d3317 ("ACPI: delete tracing macros from drivers/acpi/*.c")

I can't see any you've missed so:

Reviewed-by: Andrew Murray <andrew.murray@arm.com>


>  }
>  
>  /* --------------------------------------------------------------------------
> -- 
> 2.22.1
>
Rafael J. Wysocki Aug. 26, 2019, 9:08 a.m. UTC | #2
On Monday, August 19, 2019 3:53:24 PM CEST Krzysztof Wilczynski wrote:
> Remove unnecessary parentheses enclosing the value in a return
> statement in the drivers/acpi/pci_link.c.
> 
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
> ---
>  drivers/acpi/pci_link.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> index db11f7771ef1..00a6da2121be 100644
> --- a/drivers/acpi/pci_link.c
> +++ b/drivers/acpi/pci_link.c
> @@ -661,7 +661,7 @@ int acpi_pci_link_allocate_irq(acpi_handle handle, int index, int *triggering,
>  	ACPI_DEBUG_PRINT((ACPI_DB_INFO,
>  			  "Link %s is referenced\n",
>  			  acpi_device_bid(link->device)));
> -	return (link->irq.active);
> +	return link->irq.active;
>  }
>  
>  /*
> @@ -712,7 +712,7 @@ int acpi_pci_link_free_irq(acpi_handle handle)
>  		acpi_evaluate_object(link->device->handle, "_DIS", NULL, NULL);
>  
>  	mutex_unlock(&acpi_link_lock);
> -	return (link->irq.active);
> +	return link->irq.active;
>  }
>  
>  /* --------------------------------------------------------------------------
> 

Applied, thanks!

Patch
diff mbox series

diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
index db11f7771ef1..00a6da2121be 100644
--- a/drivers/acpi/pci_link.c
+++ b/drivers/acpi/pci_link.c
@@ -661,7 +661,7 @@  int acpi_pci_link_allocate_irq(acpi_handle handle, int index, int *triggering,
 	ACPI_DEBUG_PRINT((ACPI_DB_INFO,
 			  "Link %s is referenced\n",
 			  acpi_device_bid(link->device)));
-	return (link->irq.active);
+	return link->irq.active;
 }
 
 /*
@@ -712,7 +712,7 @@  int acpi_pci_link_free_irq(acpi_handle handle)
 		acpi_evaluate_object(link->device->handle, "_DIS", NULL, NULL);
 
 	mutex_unlock(&acpi_link_lock);
-	return (link->irq.active);
+	return link->irq.active;
 }
 
 /* --------------------------------------------------------------------------