mtd: fix oops when writing to phram device on arm64
diff mbox series

Message ID 1566221892-16744-1-git-send-email-yihuaijie@huawei.com
State Changes Requested
Headers show
Series
  • mtd: fix oops when writing to phram device on arm64
Related show

Commit Message

Huaijie Yi Aug. 19, 2019, 1:38 p.m. UTC
From: yihuaijie <yihuaijie@huawei.com>

memcpy() to memory remaped by ioremap() at an address not aligned
to 8-bytes will cause oops on arm64 platform, fixing this by using
ioremap_wc().

e.g.
writing through jffs2 on a phram device cause following error:

Unable to handle kernel paging request at virtual address ffffff800f93700c
pgd = ffffffc00385c000
[ffffff800f93700c] *pgd=0000000000000000, *pud=0000000000000000
Internal error: Oops: 96000061 [#1] PREEMPT SMP
task: ffffffc003549b10 task.stack: ffffffc0b8bc8000
PC is at __memcpy+0xc0/0x180
LR is at phram_write+0x5c/0x78 [phram]
pc : [<ffffff8008484740>] lr : [<ffffff8000d731a4>] pstate: 80000005
sp : ffffffc0b8bcb8c0
x29: ffffffc0b8bcb8c0 x28: 000000000093700c
x27: 0000000000000001 x26: 0000000000000000
x25: 0000000000000001 x24: 0000000000000000
x23: ffffffc5b6db8480 x22: ffffffc0b8bcb990
x21: ffffff800f000000 x20: 000000000093700c
x19: 0000000000000044 x18: 000000000000000a
x17: 0000000000000c00 x16: 0000000000000400
x15: 000000000001e125 x14: 34347830203a6e65
x13: 6c202c6330303733 x12: 397830203a726464
x11: 61202c3030303030 x10: 3066303038666666
x9 : 6666667830203a56 x8 : 0000000298f7fb1d
x7 : 00000044e0021985 x6 : ffffff800f93700c
x5 : 0000000000000000 x4 : 0000000000000000
x3 : ffffff8008cbe018 x2 : ffffffffffffffc4
x1 : ffffffc5b6db8490 x0 : ffffff800f93700c

Signed-off-by: Huaijie Yi <yihuaijie@huawei.com>
---
 drivers/mtd/devices/phram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Weinberger Sept. 15, 2019, 9:48 p.m. UTC | #1
On Mon, Aug 19, 2019 at 3:39 PM Huaijie Yi <yihuaijie@huawei.com> wrote:
>
> From: yihuaijie <yihuaijie@huawei.com>
>
> memcpy() to memory remaped by ioremap() at an address not aligned
> to 8-bytes will cause oops on arm64 platform, fixing this by using
> ioremap_wc().

This might be the right thing on arm64, but I fear not for all other
archs and configurations.

We had a similar chain of problems already with our sram driver.
See:
eb43e023130b ("misc: sram: add optional ioremap without write combining")
0ab163ad1ea0 ("misc: sram: switch to ioremap_wc from ioremap")

Patch
diff mbox series

diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
index c467286..32355cb 100644
--- a/drivers/mtd/devices/phram.c
+++ b/drivers/mtd/devices/phram.c
@@ -98,7 +98,7 @@  static int register_device(char *name, phys_addr_t start, size_t len)
 		goto out0;
 
 	ret = -EIO;
-	new->mtd.priv = ioremap(start, len);
+	new->mtd.priv = ioremap_wc(start, len);
 	if (!new->mtd.priv) {
 		pr_err("ioremap failed\n");
 		goto out1;