Patchwork [Oneiric,Pull,Request] Add Realtel RTS5139 card reader driver

login
register
mail settings
Submitter Keng-Yu Lin
Date Sept. 16, 2011, 2:42 a.m.
Message ID <CADXHx7YMcSRp7_DQyT938Tnh9-X1n_DY3GFZ+AXw_E61V_3ucQ@mail.gmail.com>
Download mbox
Permalink /patch/114922/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/lexical/lexical-oneiric.git rts5139

Comments

Keng-Yu Lin - Sept. 16, 2011, 2:42 a.m.
On Thu, Sep 15, 2011 at 9:59 PM, Leann Ogasawara
<leann.ogasawara@canonical.com> wrote:
> On Thu, 2011-09-15 at 11:23 +0800, Keng-Yü Lin wrote:
>> The driver is not yet mainline but is already in GregKH's staging-next.
>>
>> BugLink: http://bugs.launchpad.net/bugs/824273
>
> Hi Keng-Yü,
>
> I don't see any comments in the email or bug report that the driver has
> been tested and confirmed to enable the card reader.  I assume you've
> tested this?  Also, now that we are in Kernel Freeze for Oneiric, we are
> following our SRU policy before applying any patches.  Please add the
> SRU Justification to the bug report.
>
> Thanks,
> Leann
>

Hi Leann:
  I pushed the modified patches at the same branch.

SRU Justification:

Impact: The card reader is not usable.

Fix: include the rts5139 driver from GregKH's staging-next tree.

Test: I tested the driver on Lenovo AIO S510 and the card reader works with it.

BugLink: http://bugs.launchpad.net/bugs/824273



The following changes since commit e6abd45bab6206deab678bf2c85879ddf6a4aa32:

  UBUNTU: Ubuntu-3.0.0-11.18 (2011-09-13 12:29:19 -0700)

are available in the git repository at:
  git://kernel.ubuntu.com/lexical/lexical-oneiric.git rts5139

Greg Kroah-Hartman (1):
      UBUNTU: SAUCE: staging: rts5139: add vmalloc.h to some files to
fix the build.

Keng-Yu Lin (1):
      UBUNTU: [Config] Enable CONFIG_RTS5139=m on i386/amd64

Randy Dunlap (1):
      UBUNTU: SAUCE: staging: fix rts5139 depends & build

edwin_rong (1):
      UBUNTU: SAUCE: Staging: add driver for Realtek RTS5139 cardreader
Leann Ogasawara - Sept. 16, 2011, 2:42 p.m.
On Fri, 2011-09-16 at 10:42 +0800, Keng-Yü Lin wrote:
> On Thu, Sep 15, 2011 at 9:59 PM, Leann Ogasawara
> <leann.ogasawara@canonical.com> wrote:
> > On Thu, 2011-09-15 at 11:23 +0800, Keng-Yü Lin wrote:
> >> The driver is not yet mainline but is already in GregKH's staging-next.
> >>
> >> BugLink: http://bugs.launchpad.net/bugs/824273
> >
> > Hi Keng-Yü,
> >
> > I don't see any comments in the email or bug report that the driver has
> > been tested and confirmed to enable the card reader.  I assume you've
> > tested this?  Also, now that we are in Kernel Freeze for Oneiric, we are
> > following our SRU policy before applying any patches.  Please add the
> > SRU Justification to the bug report.
> >
> > Thanks,
> > Leann
> >
> 
> Hi Leann:
>   I pushed the modified patches at the same branch.
> 
> SRU Justification:
> 
> Impact: The card reader is not usable.
> 
> Fix: include the rts5139 driver from GregKH's staging-next tree.
> 
> Test: I tested the driver on Lenovo AIO S510 and the card reader works with it.
> 
> BugLink: http://bugs.launchpad.net/bugs/824273
> 
> 
> 
> The following changes since commit e6abd45bab6206deab678bf2c85879ddf6a4aa32:
> 
>   UBUNTU: Ubuntu-3.0.0-11.18 (2011-09-13 12:29:19 -0700)
> 
> are available in the git repository at:
>   git://kernel.ubuntu.com/lexical/lexical-oneiric.git rts5139
> 
> Greg Kroah-Hartman (1):
>       UBUNTU: SAUCE: staging: rts5139: add vmalloc.h to some files to
> fix the build.
> 
> Keng-Yu Lin (1):
>       UBUNTU: [Config] Enable CONFIG_RTS5139=m on i386/amd64
> 
> Randy Dunlap (1):
>       UBUNTU: SAUCE: staging: fix rts5139 depends & build
> 
> edwin_rong (1):
>       UBUNTU: SAUCE: Staging: add driver for Realtek RTS5139 cardreader

Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>

I've applied this to Oneiric master-next.  I slightly modified the
commit messages to note the cherry-picks were from staging-next.  Also
inserted the BugLink to each of the commits.

Thanks,
Leann