[4/9] support/graph-size: report 'Unkown" after all packages, but before "Others"
diff mbox series

Message ID d78b0de4b0e6d83ec8030fece702483debfc38e4.1566062299.git.yann.morin.1998@free.fr
State Accepted
Headers show
Series
  • Untitled series #125748
Related show

Commit Message

Yann E. MORIN Aug. 17, 2019, 5:18 p.m. UTC
Currently, the "unknown" category may be reproted anywhere, so it does
not really stand out when there are a lot of packages in the graph.

Move it towards the end, but right before the "other" category, so that
it is a bit more visible. Like for Others, don;t report it if its size
is zero.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
 support/scripts/size-stats | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Arnout Vandecappelle Aug. 26, 2019, 8:53 p.m. UTC | #1
On 17/08/2019 19:18, Yann E. MORIN wrote:
> Currently, the "unknown" category may be reproted anywhere, so it does
> not really stand out when there are a lot of packages in the graph.
> 
> Move it towards the end, but right before the "other" category, so that
> it is a bit more visible. Like for Others, don;t report it if its size
> is zero.
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> ---
>  support/scripts/size-stats | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/support/scripts/size-stats b/support/scripts/size-stats
> index 398c256e8b..82258e4606 100755
> --- a/support/scripts/size-stats
> +++ b/support/scripts/size-stats
> @@ -131,12 +131,18 @@ def draw_graph(pkgsize, outputf):
>      labels = []
>      values = []
>      other_value = 0
> +    unknown_value = 0

 A slightly more pythonesque way (IMO) would be

    unknown_value = pkgsize.pop("unknown")

(assuming that pkgsize["unknown"] doesn't get used anymore).

 But opinons may vary and I couldn't be bothered with testing my change, so
applied to next as is, thanks.

 Regards,
 Arnout

>      for (p, sz) in sorted(pkgsize.items(), key=lambda x: x[1]):
>          if sz < (total * 0.01):
>              other_value += sz
> +        elif p == "unknown":
> +            unknown_value = sz
>          else:
>              labels.append("%s (%d kB)" % (p, sz / 1000.))
>              values.append(sz)
> +    if unknown_value != 0:
> +        labels.append("Unknown (%d kB)" % (unknown_value / 1000.))
> +        values.append(unknown_value)
>      if other_value != 0:
>          labels.append("Other (%d kB)" % (other_value / 1000.))
>          values.append(other_value)
>

Patch
diff mbox series

diff --git a/support/scripts/size-stats b/support/scripts/size-stats
index 398c256e8b..82258e4606 100755
--- a/support/scripts/size-stats
+++ b/support/scripts/size-stats
@@ -131,12 +131,18 @@  def draw_graph(pkgsize, outputf):
     labels = []
     values = []
     other_value = 0
+    unknown_value = 0
     for (p, sz) in sorted(pkgsize.items(), key=lambda x: x[1]):
         if sz < (total * 0.01):
             other_value += sz
+        elif p == "unknown":
+            unknown_value = sz
         else:
             labels.append("%s (%d kB)" % (p, sz / 1000.))
             values.append(sz)
+    if unknown_value != 0:
+        labels.append("Unknown (%d kB)" % (unknown_value / 1000.))
+        values.append(unknown_value)
     if other_value != 0:
         labels.append("Other (%d kB)" % (other_value / 1000.))
         values.append(other_value)