Message ID | 20190817112638.11289-2-romain.naour@gmail.com |
---|---|
State | Accepted |
Headers | show |
Series | None | expand |
On 17/08/2019 13:26, Romain Naour wrote: > With binutils 2.30.x or 2.31.x, the assembler doesn't > support the code generated by gcc 9.1: > > Error: junk at end of line `l.movhi r17,gotoffha(.LC0)' > > gotoffha is supported by binutils since version 2.32 [1]. > It was added by the ork1 gcc port merged into gcc 9.x [2]. > > So, for or1k we can select gcc 9.x only if binutils 2.32 > (or latter) is selected. > > Tested using qemu_or1k_defconfig and selecting musl libc, > binutils 2.32 and gcc 9.1. > > [1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=1c4f3780f7d939402cfe555007ebff45c8e38951 > [2] https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=d61fdfe71cfd42aa6454f2267a48c97820918fe3 > > Signed-off-by: Romain Naour <romain.naour@gmail.com> > Cc: Waldemar Brodkorb <mail@waldemar-brodkorb.de> > --- > package/gcc/Config.in.host | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host > index 990b7964c6..9b0fbf7d11 100644 > --- a/package/gcc/Config.in.host > +++ b/package/gcc/Config.in.host > @@ -59,6 +59,8 @@ config BR2_GCC_VERSION_8_X > > config BR2_GCC_VERSION_9_X > bool "gcc 9.x" > + # or1k needs binutils >= 2.32 > + depends on !BR2_or1k || (BR2_or1k && !BR2_BINUTILS_VERSION_2_30_X && !BR2_BINUTILS_VERSION_2_31_X) I've inverted the logic here, like was done a bit higher. Also split over two lines: depends on !(BR2_or1k && \ (BR2_BINUTILS_VERSION_2_30_X || BR2_BINUTILS_VERSION_2_31_X)) Applied to master with that change, plus some spelling fixes in the commit message, thanks. Regards, Arnout > # powerpc spe support has been deprecated since gcc 8.x. > # https://gcc.gnu.org/ml/gcc/2018-04/msg00102.html > depends on !BR2_powerpc_SPE >
diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host index 990b7964c6..9b0fbf7d11 100644 --- a/package/gcc/Config.in.host +++ b/package/gcc/Config.in.host @@ -59,6 +59,8 @@ config BR2_GCC_VERSION_8_X config BR2_GCC_VERSION_9_X bool "gcc 9.x" + # or1k needs binutils >= 2.32 + depends on !BR2_or1k || (BR2_or1k && !BR2_BINUTILS_VERSION_2_30_X && !BR2_BINUTILS_VERSION_2_31_X) # powerpc spe support has been deprecated since gcc 8.x. # https://gcc.gnu.org/ml/gcc/2018-04/msg00102.html depends on !BR2_powerpc_SPE
With binutils 2.30.x or 2.31.x, the assembler doesn't support the code generated by gcc 9.1: Error: junk at end of line `l.movhi r17,gotoffha(.LC0)' gotoffha is supported by binutils since version 2.32 [1]. It was added by the ork1 gcc port merged into gcc 9.x [2]. So, for or1k we can select gcc 9.x only if binutils 2.32 (or latter) is selected. Tested using qemu_or1k_defconfig and selecting musl libc, binutils 2.32 and gcc 9.1. [1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=1c4f3780f7d939402cfe555007ebff45c8e38951 [2] https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=d61fdfe71cfd42aa6454f2267a48c97820918fe3 Signed-off-by: Romain Naour <romain.naour@gmail.com> Cc: Waldemar Brodkorb <mail@waldemar-brodkorb.de> --- package/gcc/Config.in.host | 2 ++ 1 file changed, 2 insertions(+)