[committed] Fix SH test compromised by recent forwprop changes
diff mbox series

Message ID 95e9e0f9-0e04-6b68-5504-f39fc2dba286@redhat.com
State New
Headers show
Series
  • [committed] Fix SH test compromised by recent forwprop changes
Related show

Commit Message

Jeff Law Aug. 16, 2019, 9:50 p.m. UTC
My tester threw regressions for the SH targets overnight.

This was bisect down to this patch:


commit ce1d21d251fee17a70ee9f8ff9e57620126f28c7 (refs/bisect/bad)
Author: rguenth <rguenth@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Fri Aug 16 09:27:34 2019 +0000

    2019-08-16  Richard Biener  <rguenther@suse.de>

            * tree-ssa-forwprop.c (simplify_builtin_call): Do not remove
            stmt at gsi_p, instead replace it with a NOP removed later.
            (pass_forwprop::execute): Fully propagate lattice, DCE stmts
            that became dead because of that.

            fortran/
            * trans-intrinsic.c (gfc_conv_intrinsic_findloc): Initialize
            forward_branch to avoid bogus uninitialized warning.

            * gcc.dg/tree-ssa/forwprop-31.c: Adjust.


    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@274563
138bc75d-0d04-0410-961f-82ee72b054a4

After looking at the .optimized dump as well as the resulting assembly
it's quite clear that after Richi's change the resulting code is better
(smaller & fewer branches).

The test still seems useful and can be restored to testing its original
intent by disabling forwprop.  So that's what I've done.

Installing on the trunk momentarily.

Jeff

Patch
diff mbox series

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index b9a752cedff..408897e47f4 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@ 
+2019-08-16  Jeff Law  <law@redhat.com>
+
+	* gcc.target/sh/pr54236-6.c: Use -fno-tree-forwprop.
+
 2019-08-16  Martin Sebor  <msebor@redhat.com>
 
 	* gcc.dg/struct-ret-1.c: Enable on all targets.
diff --git a/gcc/testsuite/gcc.target/sh/pr54236-6.c b/gcc/testsuite/gcc.target/sh/pr54236-6.c
index cc477927d2a..93bfeb36951 100644
--- a/gcc/testsuite/gcc.target/sh/pr54236-6.c
+++ b/gcc/testsuite/gcc.target/sh/pr54236-6.c
@@ -9,7 +9,7 @@ 
 */
 
 /* { dg-do compile }  */
-/* { dg-options "-O2" }  */
+/* { dg-options "-O2 -fno-tree-forwprop" }  */
 
 /* { dg-final { scan-assembler-times {tst	#1,r0} 1 } }  */
 /* { dg-final { scan-assembler-times {subc	r} 1 } }  */