[2/2] fwtstest: syntaxcheck-0001: update to keep in sync with ACPICA features
diff mbox series

Message ID 20190816174139.14231-3-colin.king@canonical.com
State Accepted
Headers show
Series
  • ACPICA: Update to version 20190816
Related show

Commit Message

Colin King Aug. 16, 2019, 5:41 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

We now have Legacy Processor() keyword detection, so add this
to the output from the syntaxcheck test.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 .../syntaxcheck-0001/syntaxcheck-0001.log     | 32 +++++++++++++++++--
 1 file changed, 30 insertions(+), 2 deletions(-)

Comments

Alex Hung Aug. 16, 2019, 7:51 p.m. UTC | #1
On 2019-08-16 11:41 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> We now have Legacy Processor() keyword detection, so add this
> to the output from the syntaxcheck test.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  .../syntaxcheck-0001/syntaxcheck-0001.log     | 32 +++++++++++++++++--
>  1 file changed, 30 insertions(+), 2 deletions(-)
> 
> diff --git a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
> index 40bbd149..4e3715d3 100644
> --- a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
> +++ b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
> @@ -20,6 +20,34 @@ syntaxcheck     00243|             {
>  syntaxcheck     00244|                 If (_OSI ("Linux"))
>  syntaxcheck     00245|                 {
>  syntaxcheck     ==========================================================
> +syntaxcheck     FAILED [MEDIUM] AMLAsmUnknown: Test 1, Assembler warning
> +syntaxcheck     in line 661
> +syntaxcheck     Line | AML source
> +syntaxcheck     ----------------------------------------------------------
> +syntaxcheck     00658| 
> +syntaxcheck     00659|     Scope (_PR)
> +syntaxcheck     00660|     {
> +syntaxcheck     00661|         Processor (CPU0, 0x00, 0x00001010, 0x06){}
> +syntaxcheck          |                      ^
> +syntaxcheck          | Warning 3168: Legacy Processor() keyword detected. Use Device() keyword instead.
> +syntaxcheck     00662|         Processor (CPU1, 0x01, 0x00001010, 0x06){}
> +syntaxcheck     00663|         Method (RPPC, 0, NotSerialized)
> +syntaxcheck     00664|         {
> +syntaxcheck     ==========================================================
> +syntaxcheck     FAILED [MEDIUM] AMLAsmUnknown: Test 1, Assembler warning
> +syntaxcheck     in line 662
> +syntaxcheck     Line | AML source
> +syntaxcheck     ----------------------------------------------------------
> +syntaxcheck     00659|     Scope (_PR)
> +syntaxcheck     00660|     {
> +syntaxcheck     00661|         Processor (CPU0, 0x00, 0x00001010, 0x06){}
> +syntaxcheck     00662|         Processor (CPU1, 0x01, 0x00001010, 0x06){}
> +syntaxcheck          |                      ^
> +syntaxcheck          | Warning 3168: Legacy Processor() keyword detected. Use Device() keyword instead.
> +syntaxcheck     00663|         Method (RPPC, 0, NotSerialized)
> +syntaxcheck     00664|         {
> +syntaxcheck     00665|             If (LEqual (OSYS, 0x07D2))
> +syntaxcheck     ==========================================================
>  syntaxcheck     FAILED [MEDIUM] AMLAsmASL_MSG_LOCAL_NOT_USED: Test 1,
>  syntaxcheck     Assembler warning in line 692
>  syntaxcheck     Line | AML source
> @@ -427,7 +455,7 @@ syntaxcheck     thread enters the method and blocks and then a second
>  syntaxcheck     thread also executes the method, ending up in two attempts
>  syntaxcheck     to create the object and causing a failure.
>  syntaxcheck     
> -syntaxcheck     Table DSDT (0) reassembly: Found 3 errors, 5 warnings, 17
> +syntaxcheck     Table DSDT (0) reassembly: Found 3 errors, 7 warnings, 17
>  syntaxcheck     remarks.
>  syntaxcheck     
>  syntaxcheck     
> @@ -798,6 +826,6 @@ syntaxcheck     remarks.
>  syntaxcheck     
>  syntaxcheck     
>  syntaxcheck     ==========================================================
> -syntaxcheck     2 passed, 45 failed, 0 warning, 0 aborted, 0 skipped, 0
> +syntaxcheck     2 passed, 47 failed, 0 warning, 0 aborted, 0 skipped, 0
>  syntaxcheck     info only.
>  syntaxcheck     ==========================================================
> 


Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Aug. 19, 2019, 10:49 a.m. UTC | #2
On 8/17/19 1:41 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> We now have Legacy Processor() keyword detection, so add this
> to the output from the syntaxcheck test.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  .../syntaxcheck-0001/syntaxcheck-0001.log     | 32 +++++++++++++++++--
>  1 file changed, 30 insertions(+), 2 deletions(-)
>
> diff --git a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
> index 40bbd149..4e3715d3 100644
> --- a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
> +++ b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
> @@ -20,6 +20,34 @@ syntaxcheck     00243|             {
>  syntaxcheck     00244|                 If (_OSI ("Linux"))
>  syntaxcheck     00245|                 {
>  syntaxcheck     ==========================================================
> +syntaxcheck     FAILED [MEDIUM] AMLAsmUnknown: Test 1, Assembler warning
> +syntaxcheck     in line 661
> +syntaxcheck     Line | AML source
> +syntaxcheck     ----------------------------------------------------------
> +syntaxcheck     00658| 
> +syntaxcheck     00659|     Scope (_PR)
> +syntaxcheck     00660|     {
> +syntaxcheck     00661|         Processor (CPU0, 0x00, 0x00001010, 0x06){}
> +syntaxcheck          |                      ^
> +syntaxcheck          | Warning 3168: Legacy Processor() keyword detected. Use Device() keyword instead.
> +syntaxcheck     00662|         Processor (CPU1, 0x01, 0x00001010, 0x06){}
> +syntaxcheck     00663|         Method (RPPC, 0, NotSerialized)
> +syntaxcheck     00664|         {
> +syntaxcheck     ==========================================================
> +syntaxcheck     FAILED [MEDIUM] AMLAsmUnknown: Test 1, Assembler warning
> +syntaxcheck     in line 662
> +syntaxcheck     Line | AML source
> +syntaxcheck     ----------------------------------------------------------
> +syntaxcheck     00659|     Scope (_PR)
> +syntaxcheck     00660|     {
> +syntaxcheck     00661|         Processor (CPU0, 0x00, 0x00001010, 0x06){}
> +syntaxcheck     00662|         Processor (CPU1, 0x01, 0x00001010, 0x06){}
> +syntaxcheck          |                      ^
> +syntaxcheck          | Warning 3168: Legacy Processor() keyword detected. Use Device() keyword instead.
> +syntaxcheck     00663|         Method (RPPC, 0, NotSerialized)
> +syntaxcheck     00664|         {
> +syntaxcheck     00665|             If (LEqual (OSYS, 0x07D2))
> +syntaxcheck     ==========================================================
>  syntaxcheck     FAILED [MEDIUM] AMLAsmASL_MSG_LOCAL_NOT_USED: Test 1,
>  syntaxcheck     Assembler warning in line 692
>  syntaxcheck     Line | AML source
> @@ -427,7 +455,7 @@ syntaxcheck     thread enters the method and blocks and then a second
>  syntaxcheck     thread also executes the method, ending up in two attempts
>  syntaxcheck     to create the object and causing a failure.
>  syntaxcheck     
> -syntaxcheck     Table DSDT (0) reassembly: Found 3 errors, 5 warnings, 17
> +syntaxcheck     Table DSDT (0) reassembly: Found 3 errors, 7 warnings, 17
>  syntaxcheck     remarks.
>  syntaxcheck     
>  syntaxcheck     
> @@ -798,6 +826,6 @@ syntaxcheck     remarks.
>  syntaxcheck     
>  syntaxcheck     
>  syntaxcheck     ==========================================================
> -syntaxcheck     2 passed, 45 failed, 0 warning, 0 aborted, 0 skipped, 0
> +syntaxcheck     2 passed, 47 failed, 0 warning, 0 aborted, 0 skipped, 0
>  syntaxcheck     info only.
>  syntaxcheck     ==========================================================

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch
diff mbox series

diff --git a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
index 40bbd149..4e3715d3 100644
--- a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
+++ b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
@@ -20,6 +20,34 @@  syntaxcheck     00243|             {
 syntaxcheck     00244|                 If (_OSI ("Linux"))
 syntaxcheck     00245|                 {
 syntaxcheck     ==========================================================
+syntaxcheck     FAILED [MEDIUM] AMLAsmUnknown: Test 1, Assembler warning
+syntaxcheck     in line 661
+syntaxcheck     Line | AML source
+syntaxcheck     ----------------------------------------------------------
+syntaxcheck     00658| 
+syntaxcheck     00659|     Scope (_PR)
+syntaxcheck     00660|     {
+syntaxcheck     00661|         Processor (CPU0, 0x00, 0x00001010, 0x06){}
+syntaxcheck          |                      ^
+syntaxcheck          | Warning 3168: Legacy Processor() keyword detected. Use Device() keyword instead.
+syntaxcheck     00662|         Processor (CPU1, 0x01, 0x00001010, 0x06){}
+syntaxcheck     00663|         Method (RPPC, 0, NotSerialized)
+syntaxcheck     00664|         {
+syntaxcheck     ==========================================================
+syntaxcheck     FAILED [MEDIUM] AMLAsmUnknown: Test 1, Assembler warning
+syntaxcheck     in line 662
+syntaxcheck     Line | AML source
+syntaxcheck     ----------------------------------------------------------
+syntaxcheck     00659|     Scope (_PR)
+syntaxcheck     00660|     {
+syntaxcheck     00661|         Processor (CPU0, 0x00, 0x00001010, 0x06){}
+syntaxcheck     00662|         Processor (CPU1, 0x01, 0x00001010, 0x06){}
+syntaxcheck          |                      ^
+syntaxcheck          | Warning 3168: Legacy Processor() keyword detected. Use Device() keyword instead.
+syntaxcheck     00663|         Method (RPPC, 0, NotSerialized)
+syntaxcheck     00664|         {
+syntaxcheck     00665|             If (LEqual (OSYS, 0x07D2))
+syntaxcheck     ==========================================================
 syntaxcheck     FAILED [MEDIUM] AMLAsmASL_MSG_LOCAL_NOT_USED: Test 1,
 syntaxcheck     Assembler warning in line 692
 syntaxcheck     Line | AML source
@@ -427,7 +455,7 @@  syntaxcheck     thread enters the method and blocks and then a second
 syntaxcheck     thread also executes the method, ending up in two attempts
 syntaxcheck     to create the object and causing a failure.
 syntaxcheck     
-syntaxcheck     Table DSDT (0) reassembly: Found 3 errors, 5 warnings, 17
+syntaxcheck     Table DSDT (0) reassembly: Found 3 errors, 7 warnings, 17
 syntaxcheck     remarks.
 syntaxcheck     
 syntaxcheck     
@@ -798,6 +826,6 @@  syntaxcheck     remarks.
 syntaxcheck     
 syntaxcheck     
 syntaxcheck     ==========================================================
-syntaxcheck     2 passed, 45 failed, 0 warning, 0 aborted, 0 skipped, 0
+syntaxcheck     2 passed, 47 failed, 0 warning, 0 aborted, 0 skipped, 0
 syntaxcheck     info only.
 syntaxcheck     ==========================================================