Patchwork [Oneiric,1/1] UBUNTU: SAUCE: x86: reboot: Make Dell Latitude E6220 use reboot=pci

login
register
mail settings
Submitter Leann Ogasawara
Date Sept. 15, 2011, 4:58 p.m.
Message ID <1316105927.20897.1.camel@adamo>
Download mbox | patch
Permalink /patch/114803/
State New
Headers show

Comments

Leann Ogasawara - Sept. 15, 2011, 4:58 p.m.
Hi All,

BugLink: http://bugs.launchpad.net/bugs/838402

== SRU Justification ==

It's been reported that the Dell Latitude E6220 doesn't reboot unless
using reboot=pci.  The following patch resolves this issue and has been
successfully tested.  Upstream is unfortunately not accepting any
additional quirk patches like this as they would prefer to migrate to a
more systematic approach.  Given that the patch is system specific (ie
low risk of regression), precedence for similar quirk patches already
existing, and having received positive test results, I feel it should be
carried as a SAUCE patch until a more systematic approach can be found
which upstream will accept.

== Impact ==
Affects Dell Latitude E6220 models.

== Test Case ==
Without the patch, those with a Dell Latitude E6220 must use reboot=pci
as a workaround in order for the system to successfully reboot.  With
the patch applied, the work around is no longer needed.

== Fix ==
See patch below.

From 0f6ecec81cf28e1916f52a856eff36353abe0aa3 Mon Sep 17 00:00:00 2001
From: Leann Ogasawara <leann.ogasawara@canonical.com>
Date: Fri, 26 Aug 2011 07:30:16 -0700
Subject: [PATCH] UBUNTU: SAUCE: x86: reboot: Make Dell Latitude E6220 use reboot=pci

BugLink: http://bugs.launchpad.net/bugs/838402

The Dell Latitude E6220 doesn't reboot unless reboot=pci is set.

Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>
---
 arch/x86/kernel/reboot.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
Tim Gardner - Sept. 15, 2011, 5:14 p.m.
On 09/15/2011 10:58 AM, Leann Ogasawara wrote:
> Hi All,
>
> BugLink: http://bugs.launchpad.net/bugs/838402
>
> == SRU Justification ==
>
> It's been reported that the Dell Latitude E6220 doesn't reboot unless
> using reboot=pci.  The following patch resolves this issue and has been
> successfully tested.  Upstream is unfortunately not accepting any
> additional quirk patches like this as they would prefer to migrate to a
> more systematic approach.  Given that the patch is system specific (ie
> low risk of regression), precedence for similar quirk patches already
> existing, and having received positive test results, I feel it should be
> carried as a SAUCE patch until a more systematic approach can be found
> which upstream will accept.
>
> == Impact ==
> Affects Dell Latitude E6220 models.
>
> == Test Case ==
> Without the patch, those with a Dell Latitude E6220 must use reboot=pci
> as a workaround in order for the system to successfully reboot.  With
> the patch applied, the work around is no longer needed.
>
> == Fix ==
> See patch below.
>
>  From 0f6ecec81cf28e1916f52a856eff36353abe0aa3 Mon Sep 17 00:00:00 2001
> From: Leann Ogasawara<leann.ogasawara@canonical.com>
> Date: Fri, 26 Aug 2011 07:30:16 -0700
> Subject: [PATCH] UBUNTU: SAUCE: x86: reboot: Make Dell Latitude E6220 use reboot=pci
>
> BugLink: http://bugs.launchpad.net/bugs/838402
>
> The Dell Latitude E6220 doesn't reboot unless reboot=pci is set.
>
> Signed-off-by: Leann Ogasawara<leann.ogasawara@canonical.com>
> ---
>   arch/x86/kernel/reboot.c |    8 ++++++++
>   1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
> index bd2b776..721c811 100644
> --- a/arch/x86/kernel/reboot.c
> +++ b/arch/x86/kernel/reboot.c
> @@ -435,6 +435,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E5420"),
>   		},
>   	},
> +	{       /* Handle problems with rebooting on the Latitude E6220. */
> +		.callback = set_pci_reboot,
> +		.ident = "Dell Latitude E6220",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6220"),
> +		},
> +	},
>   	{	/* Handle problems with rebooting on the Latitude E6420. */
>   		.callback = set_pci_reboot,
>   		.ident = "Dell Latitude E6420",

Acked-by: Tim Gardner <tim.gardner@canonical.com>
Seth Forshee - Sept. 15, 2011, 6:24 p.m.
On Thu, Sep 15, 2011 at 09:58:44AM -0700, Leann Ogasawara wrote:
> Hi All,
> 
> BugLink: http://bugs.launchpad.net/bugs/838402
> 
> == SRU Justification ==
> 
> It's been reported that the Dell Latitude E6220 doesn't reboot unless
> using reboot=pci.  The following patch resolves this issue and has been
> successfully tested.  Upstream is unfortunately not accepting any
> additional quirk patches like this as they would prefer to migrate to a
> more systematic approach.  Given that the patch is system specific (ie
> low risk of regression), precedence for similar quirk patches already
> existing, and having received positive test results, I feel it should be
> carried as a SAUCE patch until a more systematic approach can be found
> which upstream will accept.
> 
> == Impact ==
> Affects Dell Latitude E6220 models.
> 
> == Test Case ==
> Without the patch, those with a Dell Latitude E6220 must use reboot=pci
> as a workaround in order for the system to successfully reboot.  With
> the patch applied, the work around is no longer needed.
> 
> == Fix ==
> See patch below.
> 
> From 0f6ecec81cf28e1916f52a856eff36353abe0aa3 Mon Sep 17 00:00:00 2001
> From: Leann Ogasawara <leann.ogasawara@canonical.com>
> Date: Fri, 26 Aug 2011 07:30:16 -0700
> Subject: [PATCH] UBUNTU: SAUCE: x86: reboot: Make Dell Latitude E6220 use reboot=pci
> 
> BugLink: http://bugs.launchpad.net/bugs/838402
> 
> The Dell Latitude E6220 doesn't reboot unless reboot=pci is set.
> 
> Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>

Acked-by: Seth Forshee <seth.forshee@canonical.com>
Leann Ogasawara - Sept. 15, 2011, 6:31 p.m.
Applied to Oneiric master-next.

Thanks,
Leann

On Thu, 2011-09-15 at 09:58 -0700, Leann Ogasawara wrote:
> Hi All,
> 
> BugLink: http://bugs.launchpad.net/bugs/838402
> 
> == SRU Justification ==
> 
> It's been reported that the Dell Latitude E6220 doesn't reboot unless
> using reboot=pci.  The following patch resolves this issue and has been
> successfully tested.  Upstream is unfortunately not accepting any
> additional quirk patches like this as they would prefer to migrate to a
> more systematic approach.  Given that the patch is system specific (ie
> low risk of regression), precedence for similar quirk patches already
> existing, and having received positive test results, I feel it should be
> carried as a SAUCE patch until a more systematic approach can be found
> which upstream will accept.
> 
> == Impact ==
> Affects Dell Latitude E6220 models.
> 
> == Test Case ==
> Without the patch, those with a Dell Latitude E6220 must use reboot=pci
> as a workaround in order for the system to successfully reboot.  With
> the patch applied, the work around is no longer needed.
> 
> == Fix ==
> See patch below.
> 
> From 0f6ecec81cf28e1916f52a856eff36353abe0aa3 Mon Sep 17 00:00:00 2001
> From: Leann Ogasawara <leann.ogasawara@canonical.com>
> Date: Fri, 26 Aug 2011 07:30:16 -0700
> Subject: [PATCH] UBUNTU: SAUCE: x86: reboot: Make Dell Latitude E6220 use reboot=pci
> 
> BugLink: http://bugs.launchpad.net/bugs/838402
> 
> The Dell Latitude E6220 doesn't reboot unless reboot=pci is set.
> 
> Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>
> ---
>  arch/x86/kernel/reboot.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
> index bd2b776..721c811 100644
> --- a/arch/x86/kernel/reboot.c
> +++ b/arch/x86/kernel/reboot.c
> @@ -435,6 +435,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E5420"),
>  		},
>  	},
> +	{       /* Handle problems with rebooting on the Latitude E6220. */
> +		.callback = set_pci_reboot,
> +		.ident = "Dell Latitude E6220",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6220"),
> +		},
> +	},
>  	{	/* Handle problems with rebooting on the Latitude E6420. */
>  		.callback = set_pci_reboot,
>  		.ident = "Dell Latitude E6420",
> -- 
> 1.7.4.1
> 
> 
> 
> 
>

Patch

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index bd2b776..721c811 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -435,6 +435,14 @@  static struct dmi_system_id __initdata pci_reboot_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E5420"),
 		},
 	},
+	{       /* Handle problems with rebooting on the Latitude E6220. */
+		.callback = set_pci_reboot,
+		.ident = "Dell Latitude E6220",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6220"),
+		},
+	},
 	{	/* Handle problems with rebooting on the Latitude E6420. */
 		.callback = set_pci_reboot,
 		.ident = "Dell Latitude E6420",