| Message ID | 20190814095406.GA38531@localhost.localdomain |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | ext4: fix warning inside ext4_convert_unwritten_extents_endio | expand |
On Wed, Aug 14, 2019 at 12:54:08PM +0300, Rakesh Pandit wrote: > Really enable warning when CONFIG_EXT4_DEBUG is set and fix missing > first argument. This was introduced in commit ff95ec22cd7f ("ext4: > add warning to ext4_convert_unwritten_extents_endio") and splitting > extents inside endio would trigger it. > > Signed-off-by: Rakesh Pandit <rakesh@tuxera.com> Thanks, applied. - Ted
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 92266a2da7d6..f203bf989a4c 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -3813,8 +3813,8 @@ static int ext4_convert_unwritten_extents_endio(handle_t *handle, * illegal. */ if (ee_block != map->m_lblk || ee_len > map->m_len) { -#ifdef EXT4_DEBUG - ext4_warning("Inode (%ld) finished: extent logical block %llu," +#ifdef CONFIG_EXT4_DEBUG + ext4_warning(inode->i_sb, "Inode (%ld) finished: extent logical block %llu," " len %u; IO logical block %llu, len %u", inode->i_ino, (unsigned long long)ee_block, ee_len, (unsigned long long)map->m_lblk, map->m_len);
Really enable warning when CONFIG_EXT4_DEBUG is set and fix missing first argument. This was introduced in commit ff95ec22cd7f ("ext4: add warning to ext4_convert_unwritten_extents_endio") and splitting extents inside endio would trigger it. Signed-off-by: Rakesh Pandit <rakesh@tuxera.com> --- fs/ext4/extents.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)