[U-Boot,2/6] cbfs: Move declarations above functions
diff mbox series

Message ID 20190814030914.256689-3-sjg@chromium.org
State Superseded
Delegated to: Bin Meng
Headers show
Series
  • cbfs: Allow use before relocation / BSS
Related show

Commit Message

Simon Glass Aug. 14, 2019, 3:09 a.m. UTC
At present this file has a function at the top, above declarations. This
is normally avoided, so fix it.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 fs/cbfs/cbfs.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

Comments

Bin Meng Aug. 14, 2019, 8:40 a.m. UTC | #1
On Wed, Aug 14, 2019 at 11:09 AM Simon Glass <sjg@chromium.org> wrote:
>
> At present this file has a function at the top, above declarations. This
> is normally avoided, so fix it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  fs/cbfs/cbfs.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Patch
diff mbox series

diff --git a/fs/cbfs/cbfs.c b/fs/cbfs/cbfs.c
index af4d3c5e56..2a9edcc9a0 100644
--- a/fs/cbfs/cbfs.c
+++ b/fs/cbfs/cbfs.c
@@ -9,6 +9,11 @@ 
 #include <asm/byteorder.h>
 
 enum cbfs_result file_cbfs_result;
+static const u32 good_magic = 0x4f524243;
+static const u8 good_file_magic[] = "LARCHIVE";
+static int initialized;
+static struct cbfs_header cbfs_header;
+static struct cbfs_cachenode *file_cache;
 
 const char *file_cbfs_error(void)
 {
@@ -28,15 +33,6 @@  const char *file_cbfs_error(void)
 	}
 }
 
-
-static const u32 good_magic = 0x4f524243;
-static const u8 good_file_magic[] = "LARCHIVE";
-
-
-static int initialized;
-static struct cbfs_header cbfs_header;
-static struct cbfs_cachenode *file_cache;
-
 /* Do endian conversion on the CBFS header structure. */
 static void swap_header(struct cbfs_header *dest, struct cbfs_header *src)
 {