[U-Boot,5/6] bmips: bcm63268: add support for brcmnand
diff mbox series

Message ID 20190813191958.14360-6-noltari@gmail.com
State New
Delegated to: Daniel Schwierzeck
Headers show
Series
  • bmips: add brcmnand support
Related show

Commit Message

Álvaro Fernández Rojas Aug. 13, 2019, 7:19 p.m. UTC
BCM63268 uses 4.0 HW nand controller, which is currently supported by
brcmnand driver.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 arch/mips/dts/brcm,bcm63268.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Daniel Schwierzeck Aug. 14, 2019, 1:23 p.m. UTC | #1
Am 13.08.19 um 21:19 schrieb Álvaro Fernández Rojas:
> BCM63268 uses 4.0 HW nand controller, which is currently supported by
> brcmnand driver.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  arch/mips/dts/brcm,bcm63268.dtsi | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/mips/dts/brcm,bcm63268.dtsi b/arch/mips/dts/brcm,bcm63268.dtsi
> index f8a72ef535..5294242529 100644
> --- a/arch/mips/dts/brcm,bcm63268.dtsi
> +++ b/arch/mips/dts/brcm,bcm63268.dtsi
> @@ -141,6 +141,24 @@
>  			status = "disabled";
>  		};
>  
> +		nand: nand-controller@10000200 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			compatible = "brcm,nand-bcm6368",

if BCM63268 is already supported by brcmnand, why should it match with
your new driver?

> +				     "brcm,brcmnand-v4.0",
> +				     "brcm,brcmnand";
> +			reg-names = "nand",
> +				    "nand-cache",
> +				    "nand-int-base";
> +			reg = <0x10000200 0x180>,
> +			      <0x10000600 0x200>,
> +			      <0x100000b0 0x10>;
> +			clocks = <&periph_clk BCM63268_CLK_NAND>;
> +			clock-names = "nand";
> +
> +			status = "disabled";
> +		};
> +
>  		periph_pwr: power-controller@1000184c {
>  			compatible = "brcm,bcm6328-power-domain";
>  			reg = <0x1000184c 0x4>;
>
Álvaro Fernández Rojas Aug. 22, 2019, 9:09 a.m. UTC | #2
Hi Daniel,

“brcm,nand-bcm6368“ is the probe and interrupt part of the driver.
The core part of the driver is the one that only supports HW rev 4.0 and newer.

Best regards,
Álvaro.

Patch
diff mbox series

diff --git a/arch/mips/dts/brcm,bcm63268.dtsi b/arch/mips/dts/brcm,bcm63268.dtsi
index f8a72ef535..5294242529 100644
--- a/arch/mips/dts/brcm,bcm63268.dtsi
+++ b/arch/mips/dts/brcm,bcm63268.dtsi
@@ -141,6 +141,24 @@ 
 			status = "disabled";
 		};
 
+		nand: nand-controller@10000200 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "brcm,nand-bcm6368",
+				     "brcm,brcmnand-v4.0",
+				     "brcm,brcmnand";
+			reg-names = "nand",
+				    "nand-cache",
+				    "nand-int-base";
+			reg = <0x10000200 0x180>,
+			      <0x10000600 0x200>,
+			      <0x100000b0 0x10>;
+			clocks = <&periph_clk BCM63268_CLK_NAND>;
+			clock-names = "nand";
+
+			status = "disabled";
+		};
+
 		periph_pwr: power-controller@1000184c {
 			compatible = "brcm,bcm6328-power-domain";
 			reg = <0x1000184c 0x4>;