[U-Boot,01/10] spi: Remove MIPS dependency from Broadcom HSSPI driver.
diff mbox series

Message ID 1565708146-6769-1-git-send-email-philippe.reynes@softathome.com
State Superseded
Delegated to: Tom Rini
Headers show
Series
  • [U-Boot,01/10] spi: Remove MIPS dependency from Broadcom HSSPI driver.
Related show

Commit Message

Philippe Reynes Aug. 13, 2019, 2:55 p.m. UTC
From: Kursad Oney <kursad.oney@broadcom.com>

This IP exists in both MIPS and ARM cores, so there is no need
to tie it up to MIPS only. Remove the dependency.

Signed-off-by: Kursad Oney <kursad.oney@broadcom.com>
Reviewed-by: Philippe Reynes <philippe.reynes@softathome.com>
---
 drivers/spi/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Daniel Schwierzeck Aug. 13, 2019, 3:06 p.m. UTC | #1
On Tue, Aug 13, 2019 at 4:57 PM Philippe Reynes
<philippe.reynes@softathome.com> wrote:
>
> From: Kursad Oney <kursad.oney@broadcom.com>
>
> This IP exists in both MIPS and ARM cores, so there is no need
> to tie it up to MIPS only. Remove the dependency.
>
> Signed-off-by: Kursad Oney <kursad.oney@broadcom.com>
> Reviewed-by: Philippe Reynes <philippe.reynes@softathome.com>
> ---
>  drivers/spi/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index f459c0a..749917b 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -67,7 +67,6 @@ config ATMEL_SPI
>
>  config BCM63XX_HSSPI
>         bool "BCM63XX HSSPI driver"
> -       depends on ARCH_BMIPS

this should only show up in menuconfig when the SoC is selected where
this core is implemented. Thus this should be:

        depends on (ARCH_BMIPS || ARCH_BCM6858)

IIRC we chose this approach for the other shared BCM drivers too

>         help
>           Enable the BCM6328 HSSPI driver. This driver can be used to
>           access the SPI NOR flash on platforms embedding this Broadcom
> --
> 2.7.4
>

Patch
diff mbox series

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index f459c0a..749917b 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -67,7 +67,6 @@  config ATMEL_SPI
 
 config BCM63XX_HSSPI
 	bool "BCM63XX HSSPI driver"
-	depends on ARCH_BMIPS
 	help
 	  Enable the BCM6328 HSSPI driver. This driver can be used to
 	  access the SPI NOR flash on platforms embedding this Broadcom