From patchwork Wed Sep 14 09:23:34 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: raw-posix: Fix bdrv_flush error return values Date: Tue, 13 Sep 2011 23:23:34 -0000 From: Kevin Wolf X-Patchwork-Id: 114608 Message-Id: <1315992214-3649-1-git-send-email-kwolf@redhat.com> To: qemu-devel@nongnu.org Cc: kwolf@redhat.com bdrv_flush is supposed to use 0/-errno return values Signed-off-by: Kevin Wolf Reviewed-by: Markus Armbruster --- block/raw-posix.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index a624f56..305998d 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -839,7 +839,14 @@ static int raw_create(const char *filename, QEMUOptionParameter *options) static int raw_flush(BlockDriverState *bs) { BDRVRawState *s = bs->opaque; - return qemu_fdatasync(s->fd); + int ret; + + ret = qemu_fdatasync(s->fd); + if (ret < 0) { + return -errno; + } + + return 0; } #ifdef CONFIG_XFS