| Message ID | 20190812074531.28970-5-peterx@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | intel_iommu: Do sanity check of vfio-pci earlier | expand |
Hi Peter, On 8/12/19 9:45 AM, Peter Xu wrote: > That's never a good place to stop QEMU process... Since now we have > both the machine done sanity check and also the hotplug handler, we > can safely remove this to avoid that. > > Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: Eric Auger <eric.auger@redhat.com> Thanks Eric > --- > hw/i386/intel_iommu.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index 642dd595ed..93b26b633b 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -2932,10 +2932,6 @@ static void vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu, > VTDAddressSpace *vtd_as = container_of(iommu, VTDAddressSpace, iommu); > IntelIOMMUState *s = vtd_as->iommu_state; > > - if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) { > - vtd_panic_require_caching_mode(); > - } > - > /* Update per-address-space notifier flags */ > vtd_as->notifier_flags = new; > >
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 642dd595ed..93b26b633b 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2932,10 +2932,6 @@ static void vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu, VTDAddressSpace *vtd_as = container_of(iommu, VTDAddressSpace, iommu); IntelIOMMUState *s = vtd_as->iommu_state; - if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) { - vtd_panic_require_caching_mode(); - } - /* Update per-address-space notifier flags */ vtd_as->notifier_flags = new;
That's never a good place to stop QEMU process... Since now we have both the machine done sanity check and also the hotplug handler, we can safely remove this to avoid that. Signed-off-by: Peter Xu <peterx@redhat.com> --- hw/i386/intel_iommu.c | 4 ---- 1 file changed, 4 deletions(-)