[OpenWrt-Devel] lantiq: unify Fritz!Box LED mappings
diff mbox series

Message ID 20190811213724.3468-1-mail@david-bauer.net
State Accepted
Delegated to: David Bauer
Headers show
Series
  • [OpenWrt-Devel] lantiq: unify Fritz!Box LED mappings
Related show

Commit Message

David Bauer Aug. 11, 2019, 9:37 p.m. UTC
This commit unifies the LED mapping of the AVM Fritz!Box routers, which
have a combined Power/DSL LED.

With the stock firmware, the Power LED has the following
characteristics:

 - Blink when DSL sync is being established
 - Solid when DSL sync is present

We can't completely resemble this behavior in OpenWrt. Currently, the
Power LED is completely off, when DSL sync is missing. This is not
really helpful, as a user might have the impression, that he bricked his
device.

Instead, map the Info-LED to the state of the DSL connection.
There is no consistent behavior for the Info-LED in the stock
firmware, as the user can set it's function by himself. The DSL
connection state is one possible option for the Info LED there.

Also use the red Power LED to indicate a running upgrade, in case the
board has a two-color Power LED.

Signed-off-by: David Bauer <mail@david-bauer.net>
---
 .../linux/lantiq/files/arch/mips/boot/dts/FRITZ3370-REV2.dtsi  | 2 +-
 target/linux/lantiq/files/arch/mips/boot/dts/FRITZ7312.dts     | 3 +--
 target/linux/lantiq/files/arch/mips/boot/dts/FRITZ7320.dts     | 3 +--
 target/linux/lantiq/files/arch/mips/boot/dts/FRITZ736X.dtsi    | 3 ++-
 4 files changed, 5 insertions(+), 6 deletions(-)

Patch
diff mbox series

diff --git a/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ3370-REV2.dtsi b/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ3370-REV2.dtsi
index f23d2d2cf5..02e9589969 100644
--- a/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ3370-REV2.dtsi
+++ b/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ3370-REV2.dtsi
@@ -15,7 +15,7 @@ 
 		led-boot = &power_green;
 		led-failsafe = &power_red;
 		led-running = &power_green;
-		led-upgrade = &power_green;
+		led-upgrade = &power_red;
 
 		led-dsl = &dsl;
 		led-internet = &info_green;
diff --git a/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ7312.dts b/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ7312.dts
index 811f78f934..0190dd2f01 100644
--- a/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ7312.dts
+++ b/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ7312.dts
@@ -18,8 +18,7 @@ 
 		led-running = &power;
 		led-upgrade = &power;
 
-		led-internet = &info_green;
-		led-dsl = &power;
+		led-dsl = &info_green;
 		led-wifi = &wlan;
 	};
 
diff --git a/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ7320.dts b/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ7320.dts
index 40348b1d59..6c0dad873f 100644
--- a/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ7320.dts
+++ b/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ7320.dts
@@ -18,8 +18,7 @@ 
 		led-running = &power;
 		led-upgrade = &power;
 
-		led-internet = &info_green;
-		led-dsl = &power;
+		led-dsl = &info_green;
 		led-wifi = &wlan;
 	};
 
diff --git a/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ736X.dtsi b/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ736X.dtsi
index 82546a3572..57033eb4a9 100644
--- a/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ736X.dtsi
+++ b/target/linux/lantiq/files/arch/mips/boot/dts/FRITZ736X.dtsi
@@ -17,7 +17,8 @@ 
 		led-boot = &power_green;
 		led-failsafe = &power_red;
 		led-running = &power_green;
-		led-upgrade = &power_green;
+		led-upgrade = &power_red;
+
 		led-dsl = &info_green;
 		led-wifi = &wifi;
 	};